Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4527 +/- ##
==========================================
- Coverage 73.36% 73.35% -0.02%
==========================================
Files 479 479
Lines 17505 17505
Branches 3445 3445
==========================================
- Hits 12843 12840 -3
- Misses 3782 3785 +3
Partials 880 880 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm having trouble [*] verifying the fix but the integration test shows that it uploads the symbol file reported missing in #4482. Is that a sufficient confirmation, or how should we proceed with this? [*] I have a brand new iPhone Air running iOS 26, and an old iPhone 6S stuck on iOS 15. Neither of them seems good for verifying this fix because the former is too new i.e. not yet fully supported, and the latter might just be too old as even |
We could do a pre-release. On the other hand, if an Integration Test is covering and asserting the scenario, it LGTM. Could this cause any unintended regression? If it might be "dangerous" without further testing, I am leaning towards a pre-release. If it cannot break existing scenarios, but may not actually fix all affected scenarios, I am leaning towards merging. What do you prefer? |
|
I'm leaning towards merging. All we do is pass an extra wildcard argument to Although, as @jamescrosswell brought up in #4482, it's a bit unclear why these files are not available on the Microsoft symbol server that the user had enabled:
|
|
jamescrosswell
left a comment
There was a problem hiding this comment.
No reason not to merge this I don't think.
Thanks @jpnurmi !
Co-authored-by: James Crosswell <[email protected]>

Upload
linked/*.pdb(instead of justlinked/$(AssemblyName).pdbadded for Mac Catalyst in #4503) to make missing symbols available on iOS withEnableAssemblyILStripping=falseas reported in:Close: #4482