Add support for v3 of the AssemblyStore format by jamescrosswell · Pull Request #4516 · getsentry/sentry-dotnet

jamescrosswell · 2025-09-12T02:59:05Z

Resolves #4491

Add support for AssemblyStore v3 #4491

Warning

This is a fork of the net10 branch... once that branch has been squashed/merged into the v6 branch we can look at squashing/merging into the same

Resolves #4491 - #4491

codecov · 2025-09-18T01:41:13Z

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.93%. Comparing base (44ce68a) to head (55c38fa).

Files with missing lines	Patch %	Lines
...Android.AssemblyReader/V2/AssemblyStoreExplorer.cs	60.00%	2 Missing ⚠️
...try.Android.AssemblyReader/V2/AssemblyStoreItem.cs	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            net10    #4516      +/-   ##
==========================================
+ Coverage   71.77%   72.93%   +1.15%     
==========================================
  Files         479      476       -3     
  Lines       17508    17213     -295     
  Branches     3442     3419      -23     
==========================================
- Hits        12567    12554      -13     
+ Misses       4090     3808     -282     
  Partials      851      851

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bruno-garcia

consider renaming the file, other than that LGTM

src/Sentry.Android.AssemblyReader/V2/StoreReader.cs

test/Sentry.Android.AssemblyReader.Tests/ApiApprovalTests.Run.DotNet10_0.verified.txt

This reverts commit 5f9cffa, reversing changes made to d3aa5bc.

jpnurmi · 2025-09-28T16:44:49Z

.github/actions/environment/action.yml

        brew install mono || true
        brew link --overwrite mono

-    - name: Install Mono (Ubuntu)


Was this intentionally removed, or did something go wrong with the merges?

Definitely something wrong with the merges... which is painful. Looks like I'll have to roll it all back manually.

Flash0ver · 2025-09-29T16:32:31Z

CHANGELOG.md

- Bump Cocoa SDK from v8.55.1 to v8.56.0 ([#4528](https://github.com/getsentry/sentry-dotnet/pull/4528))
-  - [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8560)
-  - [diff](https://github.com/getsentry/sentry-cocoa/compare/8.55.1...8.56.0)
- Bump CLI from v2.53.0 to v2.54.0 ([#4541](https://github.com/getsentry/sentry-dotnet/pull/4541))
-  - [changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md#2540)
-  - [diff](https://github.com/getsentry/sentry-cli/compare/2.53.0...2.54.0)
- Bump Native SDK from v0.10.1 to v0.11.0 ([#4542](https://github.com/getsentry/sentry-dotnet/pull/4542))
-  - [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#0110)
-  - [diff](https://github.com/getsentry/sentry-native/compare/0.10.1...0.11.0)


These downgrades (see also Directory.Build.props, modules/sentry-cocoa.properties, modules/sentry-native, ...) don't seem intended, are they?

Flash0ver · 2025-09-29T16:32:50Z

test/Sentry.Tests/SentrySdkTests.cs

-    [Theory]
-    [InlineData(true)]
-    [InlineData(false)]
-    public void ProcessOnBeforeSend_NativeErrorSuppressionBeforeHubInit(bool suppressNativeErrors)


Is this removal intended?

cursor · 2025-09-30T23:35:41Z

src/Sentry.Android.AssemblyReader/V2/StoreReader.cs

    }

-    public StoreReaderV2(Stream store, string path, DebugLogger? logger)
+    public StoreReader(Stream store, string path, DebugLogger? logger)


Bug: StoreReader Compilation Issues Affect Backward Compatibility

The StoreReader has inconsistent conditional compilation for assembly store format versions and the ignore byte. This can lead to incorrect parsing when built for certain target frameworks, and also prevents backward compatibility, as .NET 10+ builds currently only support v3, failing to read .NET 9 (v2) APKs.

Resolves #4491 - #4491 Replaces #4516

jamescrosswell · 2025-09-30T23:54:29Z

Replaced with #4576

Resolves #4491 - #4491 Replaces #4516 > [!WARNING] > This is a fork of the net10 branch... once that branch has been squashed/merged into the v6 branch we can look at squashing/merging into the same

Add support for v3 of the AssemblyStore format

a76a137

Resolves #4491 - #4491

jamescrosswell linked an issue Sep 12, 2025 that may be closed by this pull request

Add support for AssemblyStore v3 #4491

Closed

This was referenced Sep 12, 2025

Add support for net10.0 #4456

Closed

Support .NET 10 #4173

Closed

Format code

8e28d70

jamescrosswell mentioned this pull request Sep 12, 2025

Remove Sentry.Android.AssemblyReader package #4466

Closed

Merge branch 'net10' into assembly-store-3

c2f5bed

jamescrosswell added 2 commits September 18, 2025 16:21

Fixed AndroidAssemblyReader tests

05e17a2

Update CHANGELOG.md

9f96217

jamescrosswell mentioned this pull request Sep 21, 2025

Sentry.Extensions.Logging issue with Blazor WebAssembly in .NET 10 RC 1 #4550

Closed

jamescrosswell marked this pull request as ready for review September 22, 2025 20:55

jamescrosswell requested a review from Flash0ver as a code owner September 22, 2025 20:56

bruno-garcia approved these changes Sep 22, 2025

View reviewed changes

src/Sentry.Android.AssemblyReader/V2/StoreReader.cs Show resolved Hide resolved

Flash0ver reviewed Sep 24, 2025

View reviewed changes

test/Sentry.Android.AssemblyReader.Tests/ApiApprovalTests.Run.DotNet10_0.verified.txt Show resolved Hide resolved

Flash0ver approved these changes Sep 24, 2025

View reviewed changes

jamescrosswell added 4 commits September 25, 2025 10:53

Renamed v2 classes and remove remaining vestiges of v1

d3aa5bc

Merge branch 'main' into assembly-store-3

5f9cffa

Revert "Merge branch 'main' into assembly-store-3"

29abe0a

This reverts commit 5f9cffa, reversing changes made to d3aa5bc.

Merge branch 'net10' into assembly-store-3

55c38fa

This comment was marked as outdated.

Sign in to view

jpnurmi reviewed Sep 28, 2025

View reviewed changes

Flash0ver reviewed Sep 29, 2025

View reviewed changes

Merge branch 'net10' into assembly-store-3

fee26aa

This comment was marked as outdated.

Sign in to view

Fix accidental merge changes

61254ed

This comment was marked as outdated.

Sign in to view

.

9faa32e

cursor bot reviewed Sep 30, 2025

View reviewed changes

jamescrosswell added a commit that referenced this pull request Sep 30, 2025

Add support for v3 of the AssemblyStore format

2599d15

Resolves #4491 - #4491 Replaces #4516

jamescrosswell mentioned this pull request Sep 30, 2025

Add support for v3 of the AssemblyStore format #4576

Closed

jamescrosswell closed this Sep 30, 2025

jamescrosswell mentioned this pull request Oct 1, 2025

Android AssemblyStore v3 #4583

Merged

Uh oh!

Comments

Conversation

jamescrosswell commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bruno-garcia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

jpnurmi Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

jamescrosswell Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Flash0ver Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Flash0ver Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot Sep 30, 2025

Choose a reason for hiding this comment

Bug: StoreReader Compilation Issues Affect Backward Compatibility

Uh oh!

jamescrosswell commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jamescrosswell commented Sep 12, 2025 •

edited

Loading

codecov bot commented Sep 18, 2025 •

edited

Loading