Merged
Conversation
aritchie
approved these changes
Apr 15, 2025
Contributor
aritchie
left a comment
aritchie
left a comment
There was a problem hiding this comment.
The deeper we go with this, the more it seems we should consider a slim binding in the near future
Collaborator
Author
Possibly yes. If we had slim bindings, I wouldn't have had to add all these methods to satisfy the "missing class" errors for classes referred to by the new objective sharpie code. On the other hand, once we have slim bindings, we don't have any easy mechanism to keep these up to date if/when the CocoaSDK API's change... or I guess we would - that would be our unit tests. So we're really need to make sure we had good coverage in our device/integration tests for all the bindings code in that case. |
jamescrosswell
added a commit
that referenced
this pull request
May 19, 2025
This reverts commit 690a169
jamescrosswell
added a commit
that referenced
this pull request
May 20, 2025
jpnurmi
added a commit
that referenced
this pull request
Aug 6, 2025
3 tasks
jpnurmi
added a commit
that referenced
this pull request
Aug 12, 2025
jamescrosswell
added a commit
that referenced
this pull request
Aug 13, 2025
jamescrosswell
added a commit
that referenced
this pull request
Aug 18, 2025
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This was referenced Oct 20, 2025
This was referenced Nov 3, 2025
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the Cocoa SDK to version 8.46, which is the oldest version which would be stable for implementing Session Replay (needed to implement #2136).
I also tidied up the
scripts/generate-cocoa-bindings.ps1script a bit. It was starting to get quite large, mostly because we were using it to add lots of API contracts from theSentry-Swift.hfile (rather than tweak contracts generated by objective sharpie). There didn't seem much point in using PowerShell to write static C# code so I moved that stuff out to the following files (where we at least get syntax checking and analysers from the IDE):src/Sentry.Bindings.Cocoa/SwiftApiDefinitions.cssrc/Sentry.Bindings.Cocoa/SwiftStructsAndEnums.csThis hopefully makes the cocoa bindings script a bit easier to read and maintain.