Use pre-built version of sentry-cocoa SDK#3727
Merged
bruno-garcia merged 7 commits intomainfrom Nov 6, 2024
Merged
Conversation
jamescrosswell
changed the title
bruno-garcia
requested changes
Nov 5, 2024
bricefriha
approved these changes
Nov 6, 2024
Contributor
bricefriha
left a comment
bricefriha
left a comment
There was a problem hiding this comment.
As far as I'm concerned,
looks fine!
bruno-garcia
approved these changes
Nov 6, 2024
Member
|
I was a big fan of the flexibility of modifying the underlying library, pushing a branch and having a feature cut through that way but I realize it's a lot of overhead for this very rarely used benefit. |
This was referenced Sep 15, 2025
jpnurmi
added a commit
that referenced
this pull request
Sep 18, 2025
This reverts "Use pre-built version of sentry-cocoa SDK (#3727)" commit d179ec9 and restores the modules/sentry-cocoa Git module checked out at: getsentry/sentry-cocoa#6193
This was referenced Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address difficulties we've been having bumping the sentry-cocoa version in this repo (e.g here).
In this PR, instead of including the sentry-cocoa repo as a git submodule and building this ourselves, we're downloading the most recent release (similar to what is being done in the Unity repo).