Session Replay: Recording on Android#3552
Conversation
bruno-garcia
requested review from
bitsandfoxes and
jamescrosswell
as code owners
|
I'd love to test this out on Symbol Collector. How about we make a it'll run on hundreds of devices. |
You mean make a release from this branch? We could definitely do that... just mark it |
| #if ANDROID | ||
| options.Native.ExperimentalOptions.SessionReplay.OnErrorSampleRate = 1.0; | ||
| options.Native.ExperimentalOptions.SessionReplay.SessionSampleRate = 1.0; | ||
| options.Native.ExperimentalOptions.SessionReplay.RedactAllImages = false; | ||
| options.Native.ExperimentalOptions.SessionReplay.RedactAllText = false; | ||
| #endif |
There was a problem hiding this comment.
In the future, we should probably have a facade that configures options for the current platform (Android/iOS), instead of letting the user specify them multiple times.
There was a problem hiding this comment.
In the future, we should probably have a facade that configures options for the current platform (Android/iOS), instead of letting the user specify them multiple times.
If the options had the same name for both iOS and Android (OnErrorSampleRate, SessionSampleRate etc.) then presumably SDK users could write something like this, even without any facade:
#if ANDROID || IOS
options.Native.ExperimentalOptions.SessionReplay.OnErrorSampleRate = 1.0;
options.Native.ExperimentalOptions.SessionReplay.SessionSampleRate = 1.0;
options.Native.ExperimentalOptions.SessionReplay.RedactAllImages = false;
options.Native.ExperimentalOptions.SessionReplay.RedactAllText = false;
#endif
When targeting android, options.Native would resolve to the appropriate platform specific options at build no?
|
cc @bricefriha something we'd like to push through once the open issues are under control |
|
would love to try this too on Symbol Collector. cc @jamescrosswell |
Is there anything blocking that? Can't we just make a pre-release from this branch? Or is it more about having someone integrated it into the Symbol Collector? |
Other than CI being red, nothing blocking this |
|
woo it's green! THanks @jamescrosswell can we merge this in? (it's an experimental feature so not too worried about lack of docs for example) |
This reverts commit ad80795.
3 participants
Recording and redaction works fine on MAUI because it's all native under the hood.
To complete this we need to get breadcrumbs from C#, trace/replay id to the C# layer and other features.
References
Relates to: