chore: Adding AOT check to demo crash#3273
Merged
bitsandfoxes merged 2 commits intomainfrom Apr 10, 2024
Merged
Conversation
Collaborator
|
Awesome, thanks @bitsandfoxes.
We could. It's less about the stuff I covered in that blog post and more about the hooks into Sentry Native that @vaind added I think. Possibly there is already a good explanation in the PR(s) for the changes Ivan made? |
jamescrosswell
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3244
The native crash support requires AOT.
Can/should we link some additional info in the log? @jamescrosswell blogpost?
#skip-changelog