Support transaction finishing automatically with 'idle timeout'#2452
Support transaction finishing automatically with 'idle timeout'#2452bitsandfoxes merged 36 commits intomainfrom
Conversation
dd874d2 to
1a03d78
Compare
I imagine SDK users would want to do this by passing in a timeout via one of the Hub.StartTransaction extensions. We probably need those additional extension methods before this functionality would be usable then right? @SeanFeldman maybe worth showing how this would work in one of the sample projects, as a bit of a smoke test to make sure this is all wired up? |
I don't know if it should be just an option or also an explicit option via extensions. For example, Java has it on @bruno-garcia or @bitsandfoxes, do you have some context to share? Thank you. |
@jamescrosswell, yep. That will be the last step once I know everything that's needed is in place. |
I'm fine with having it as an explicit option. Maybe I'm missing something but what would be the benefit of putting it on the extension? |
This comment was marked as outdated.
This comment was marked as outdated.
@bruno-garcia, to confirm, you're saying we shouldn't add an extension method and stick to the initial |
…en set + revert public API change
This comment was marked as resolved.
This comment was marked as resolved.
|
I'll be honest, I'm concerned this is opened for 3 weeks and is still in draft. But I haven't really looked at it since my first round of comments. @bitsandfoxes what are the next steps here? |
bitsandfoxes
left a comment
There was a problem hiding this comment.
This looks good to me!
Co-authored-by: Stefan Jandl <[email protected]>
…tally removed during review)
jamescrosswell
left a comment
There was a problem hiding this comment.
Looks good to me!
Co-authored-by: Stefan Jandl <[email protected]>
Co-authored-by: Stefan Jandl <[email protected]>
|
🚀 |
Fixes #1074
Add support to specify transaction idle timeout to finish an idling transaction.
AddSentryOptionsdocumentation under common optionsTransactionTracerconstructors for testing in milestone for v4 --> Internalize TransactionTracer constructors used for testing #2481