Skip to content

Migration page for Dart and Flutter v7#6090

Merged
marandaneto merged 15 commits into
masterfrom
chore/dartv7
Jan 20, 2023
Merged

Migration page for Dart and Flutter v7#6090
marandaneto merged 15 commits into
masterfrom
chore/dartv7

Conversation

@marandaneto

@marandaneto marandaneto commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

@vercel

vercel Bot commented Jan 17, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 4:48PM (UTC)

@marandaneto
marandaneto marked this pull request as ready for review January 17, 2023 14:09
@marandaneto
marandaneto requested a review from a team as a code owner January 17, 2023 14:09
@marandaneto
marandaneto requested a review from lizokm January 17, 2023 14:09

@krystofwoldrich krystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@lizokm lizokm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I'm not certain that I'm interpreting this correctly. Please let me know if I've changed the intended meaning or if you want to talk about any of the suggestions.

Comment thread src/platforms/dart/migration.mdx Outdated
Comment thread src/platforms/dart/migration.mdx Outdated
Comment thread src/platforms/dart/migration.mdx Outdated
Comment thread src/platforms/dart/migration.mdx Outdated
Comment thread src/platforms/dart/migration.mdx Outdated
Comment thread src/platforms/dart/migration.mdx Outdated
Comment thread src/platforms/dart/migration.mdx Outdated
@marandaneto

Copy link
Copy Markdown
Contributor Author

@lizokm I've applied the suggestions and did a few fixes as well, this is ready for re-review.
Thanks in advance.

@lizokm lizokm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Just a few small tweaks.

Comment thread src/platforms/flutter/migration.mdx Outdated
Comment thread src/platforms/dart/migration.mdx Outdated
Comment thread src/platforms/dart/migration.mdx Outdated
@marandaneto
marandaneto enabled auto-merge (squash) January 20, 2023 16:35
@marandaneto
marandaneto merged commit 6b36909 into master Jan 20, 2023
@marandaneto
marandaneto deleted the chore/dartv7 branch January 20, 2023 16:43
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants