Skip to content

Comments

Add initial Qt documentation#3370

Merged
Swatinem merged 8 commits intogetsentry:masterfrom
torarnv:master
Apr 9, 2021
Merged

Add initial Qt documentation#3370
Swatinem merged 8 commits intogetsentry:masterfrom
torarnv:master

Conversation

@torarnv
Copy link
Contributor

@torarnv torarnv commented Apr 8, 2021

No description provided.

@torarnv torarnv requested a review from a team April 8, 2021 15:49
@vercel
Copy link

vercel bot commented Apr 8, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/BnG4ar2CVYA4EG2g58Mk9dZTMsDA
✅ Preview: https://sentry-docs-git-fork-torarnv-master.sentry.dev

@torarnv
Copy link
Contributor Author

torarnv commented Apr 8, 2021

@bruno-garcia

@torarnv
Copy link
Contributor Author

torarnv commented Apr 8, 2021

(this PR depends on a bump to the platformicons in getsentry/platformicons#40)

PeloWriter
PeloWriter reviewed Apr 8, 2021
View reviewed changes
Copy link
Contributor

@PeloWriter PeloWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this content. I won't approve until the required tests pass (I've spotted the errors that are causing the linkchecker to fail).

@torarnv
Copy link
Contributor Author

torarnv commented Apr 8, 2021

I've pulled out all the change to PlatformLink, as they are not needed for the Qt docs.

@torarnv
Copy link
Contributor Author

torarnv commented Apr 8, 2021

I do not understand the link failures i https://github.com/getsentry/sentry-docs/pull/3370/checks?check_run_id=2299482771

Can you help point me to how to fix or silence this? :)

PeloWriter
PeloWriter reviewed Apr 8, 2021
View reviewed changes
Copy link
Contributor

@PeloWriter PeloWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing a couple of links.

torarnv
torarnv commented Apr 8, 2021
View reviewed changes
@torarnv
Copy link
Contributor Author

torarnv commented Apr 8, 2021

Hurray, all green! 😄

PeloWriter
PeloWriter reviewed Apr 8, 2021
View reviewed changes
@bruno-garcia bruno-garcia mentioned this pull request Apr 8, 2021
Merged
@bruno-garcia bruno-garcia requested a review from PeloWriter April 8, 2021 23:11
PeloWriter
PeloWriter approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@PeloWriter PeloWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks structurally sound to me.

@Swatinem Swatinem merged commit 51956e7 into getsentry:master Apr 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@Swatinem Swatinem Swatinem approved these changes

@PeloWriter PeloWriter PeloWriter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@torarnv @Swatinem @PeloWriter