Skip to content

Comments

Add documentation for Offline integration#3191

Merged
PeloWriter merged 2 commits intogetsentry:masterfrom
joshkel:offline
Mar 5, 2021
Merged

Add documentation for Offline integration#3191
PeloWriter merged 2 commits intogetsentry:masterfrom
joshkel:offline

Conversation

@joshkel
Copy link
Contributor

@joshkel joshkel commented Mar 4, 2021

See getsentry/sentry-javascript#2778

Remove backticks from plugin.mdx's description; PageGrid doesn't render them as monospace, so they appear as literals in the index page, and the default.mdx description doesn't use them for its class names.

See getsentry/sentry-javascript#2778

Remove backticks from plugin.mdx's description; PageGrid doesn't render them as monospace, so they appear as literals in https://docs.sentry.io/platforms/javascript/configuration/integrations/, and the default.mdx description doesn't use them for its class names.
@joshkel joshkel requested a review from rhcarvalho as a code owner March 4, 2021 13:56
@vercel
Copy link

vercel bot commented Mar 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/GWB4q2xr9DPVFqFyNKTWpg3hnnJ3
✅ Preview: https://sentry-docs-git-fork-joshkel-offline.sentry.dev

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggested edits for style

@PeloWriter
Copy link
Contributor

Looks good. Thanks very much.

@PeloWriter PeloWriter merged commit c979e6d into getsentry:master Mar 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants