Skip to content

Upgrade the Dart/Flutter SDK to v4#2599

Merged
marandaneto merged 56 commits into
masterfrom
ref/flutter-v4
Nov 26, 2020
Merged

Upgrade the Dart/Flutter SDK to v4#2599
marandaneto merged 56 commits into
masterfrom
ref/flutter-v4

Conversation

@marandaneto

@marandaneto marandaneto commented Oct 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

To address:

  1. Should we create the Dart platform and make this a fallback to Flutter? like Java/Android
  2. Should we make Dart v3 a legacy like Java does and new docs are only v4? (Like Java v1 and v3)
  3. Do we need a migration page or just the new docs like Java docs? so with all the samples, people can learn the difference anyway.

cc @bruno-garcia @rxlabz
open for early feedback, obviously there's nothing yet, but the questions above would be nice to discuss @bruno-garcia

@vercel

vercel Bot commented Oct 27, 2020 •
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/4ka30p6wo/sentry.dev
✅ Preview: https://sentry-docs-git-ref-flutter-v4.sentry.dev

marandaneto
marandaneto commented Oct 27, 2020
View reviewed changes
Comment thread src/platforms/flutter/index.mdx Outdated
@marandaneto

marandaneto commented Oct 27, 2020

Copy link
Copy Markdown
Contributor Author

Flutter platform only for now.
PR for flutter cookbook once v4 is GA.
Migration page.

bruno-garcia
bruno-garcia reviewed Oct 27, 2020
View reviewed changes
Comment thread src/platforms/flutter/index.mdx Outdated
Comment thread src/platforms/flutter/index.mdx Outdated
@marandaneto marandaneto mentioned this pull request Oct 27, 2020
Merged
8 tasks
marandaneto
marandaneto commented Oct 28, 2020
View reviewed changes
Comment thread src/includes/configure-scope/flutter.mdx Outdated
marandaneto
marandaneto commented Oct 28, 2020
View reviewed changes
Comment thread src/includes/sensitive-data/set-tag/flutter.mdx Outdated
marandaneto
marandaneto commented Oct 28, 2020
View reviewed changes
Comment thread src/includes/sensitive-data/set-user/flutter.mdx Outdated
marandaneto
marandaneto commented Oct 28, 2020
View reviewed changes
Comment thread src/includes/before-breadcrumb/flutter.mdx Outdated
marandaneto
marandaneto commented Oct 28, 2020
View reviewed changes
Comment thread src/includes/capture-error/flutter.mdx Outdated
@marandaneto

marandaneto commented Oct 28, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

TODO (if they make sense):

decluttering
drain-example
getting-started-next-steps
getting-started-primer

bruno-garcia
bruno-garcia reviewed Nov 25, 2020
View reviewed changes

@bruno-garcia bruno-garcia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful :)

image

It's odd that we say Health here because there's no support for release health. But the docs talk about release which makes sense.

image

IHMO showing this is just noise and should be deleted:
image

Can we opt out from this?

Comment thread src/platforms/dart/index.mdx
Comment thread src/platforms/dart/index.mdx Outdated
Comment thread src/platforms/dart/index.mdx
Comment thread src/includes/configure-scope/dart.mdx Outdated
Comment thread src/platforms/dart/config.yml Outdated
Comment thread src/platforms/flutter/config.yml Outdated
Comment thread src/platforms/flutter/config.yml
Comment thread src/platforms/flutter/index.mdx Outdated
Comment thread src/wizard/dart/index.md Outdated
marandaneto
marandaneto commented Nov 25, 2020
View reviewed changes
Comment thread src/wizard/dart/index.md Outdated
bruno-garcia
bruno-garcia approved these changes Nov 25, 2020
View reviewed changes

@bruno-garcia bruno-garcia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 last fix: Hide the User Feedback page:

https://sentry-docs-git-ref-flutter-v4.sentry.dev/platforms/flutter/enriching-events/user-feedback/

Other than that looks good to merge already! We can do another iteration after that for any details

@marandaneto

marandaneto commented Nov 26, 2020

Copy link
Copy Markdown
Contributor Author

1 last fix: Hide the User Feedback page:

https://sentry-docs-git-ref-flutter-v4.sentry.dev/platforms/flutter/enriching-events/user-feedback/

Other than that looks good to merge already! We can do another iteration after that for any details

good catch, I've hidden for dart but looks like we need both

@marandaneto
marandaneto merged commit 013c875 into master Nov 26, 2020
@marandaneto
marandaneto deleted the ref/flutter-v4 branch November 26, 2020 09:22
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes
+2 more reviewers
@rxlabz rxlabz rxlabz left review comments
@MimiDumpling MimiDumpling MimiDumpling left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marandaneto @bruno-garcia @rxlabz @MimiDumpling