Skip to content

Comments

docs(dotnet/logs): add Logs for the .NET SDK#14583

Merged
Flash0ver merged 7 commits intomasterfrom
docs/add-dotnet-logs
Aug 13, 2025
Merged

docs(dotnet/logs): add Logs for the .NET SDK#14583
Flash0ver merged 7 commits intomasterfrom
docs/add-dotnet-logs

Conversation

@Flash0ver
Copy link
Member

@Flash0ver Flash0ver commented Aug 7, 2025 •
edited
Loading

DESCRIBE YOUR PR

Add documentation for Sentry Structed Logs for dotnet.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@Flash0ver Flash0ver self-assigned this Aug 7, 2025
@vercel
Copy link

vercel bot commented Aug 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
sentry-docs ✅ Ready Preview Comment Aug 13, 2025 2:49pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored Preview Aug 13, 2025 2:49pm

@codeowner-assignment codeowner-assignment bot requested a review from a team August 7, 2025 15:00
@bruno-garcia
Copy link
Member

bruno-garcia commented Aug 7, 2025

Oh it's draft, sorry I might have jumped the gun tagging @AbhiPrasad and @cleptric here

@codecov
Copy link

codecov bot commented Aug 7, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 3.75kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.85MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.38MB 3.75kB (0.03%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/9rWfUVDgm8OYQEgCqpNwb/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/9rWfUVDgm8OYQEgCqpNwb/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.77MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 1.25kB 744.9kB 0.17%
../app/platform-redirect/page.js.nft.json 1.25kB 744.82kB 0.17%
../app/sitemap.xml/route.js.nft.json 1.25kB 742.29kB 0.17%

AbhiPrasad
AbhiPrasad reviewed Aug 7, 2025
View reviewed changes
Flash0ver
Flash0ver commented Aug 11, 2025
View reviewed changes
Flash0ver
Flash0ver commented Aug 11, 2025
View reviewed changes
@Flash0ver Flash0ver marked this pull request as ready for review August 12, 2025 10:08
@Flash0ver Flash0ver requested review from a team and AbhiPrasad August 12, 2025 12:04
AbhiPrasad
AbhiPrasad approved these changes Aug 12, 2025
View reviewed changes
docs/product/explore/logs/getting-started/index.mdx
/>
- <LinkWithPlatformIcon
platform="dotnet.maui"
label="MAUI"
Copy link
Contributor

@AbhiPrasad AbhiPrasad Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to put this under the ### Mobile header?

Copy link
Member Author

@Flash0ver Flash0ver Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want to move it into Mobile ... but we could imagine copying it there as well ... but we're uncertain about the duplication

coolguyzone
coolguyzone reviewed Aug 12, 2025
View reviewed changes
coolguyzone
coolguyzone approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamescrosswell
Copy link
Collaborator

jamescrosswell commented Aug 13, 2025

Worth mentioning structured logs in the Overview of the features for the Microsoft.Extensions.Logging integration I think:
image

jamescrosswell
jamescrosswell reviewed Aug 13, 2025
View reviewed changes
jamescrosswell
jamescrosswell reviewed Aug 13, 2025
View reviewed changes
jamescrosswell
jamescrosswell reviewed Aug 13, 2025
View reviewed changes
jamescrosswell
jamescrosswell approved these changes Aug 13, 2025
View reviewed changes
Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I think for .NET we could emphasise usage via ILogger (since this is so ubiquitous in .NET and how the vast majority of SDK users will want to create logs).

@Flash0ver Flash0ver mentioned this pull request Aug 13, 2025
Merged
6 tasks
@Flash0ver Flash0ver merged commit 482fa37 into master Aug 13, 2025
13 checks passed
@Flash0ver Flash0ver deleted the docs/add-dotnet-logs branch August 13, 2025 14:56
@Flash0ver Flash0ver mentioned this pull request Aug 21, 2025
Merged
6 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jamescrosswell jamescrosswell jamescrosswell approved these changes

@coolguyzone coolguyzone coolguyzone approved these changes

@cleptric cleptric Awaiting requested review from cleptric

+1 more reviewer

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Flash0ver Flash0ver

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Flash0ver @bruno-garcia @jamescrosswell @AbhiPrasad @coolguyzone