Fix: Capture Callback Exceptions#990
Merged
Merged
Conversation
denrase
marked this pull request as ready for review
August 31, 2022 10:12
marandaneto
reviewed
Sep 2, 2022
marandaneto
reviewed
Sep 2, 2022
marandaneto
reviewed
Sep 2, 2022
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
==========================================
+ Coverage 89.47% 89.66% +0.18%
==========================================
Files 106 106
Lines 3326 3329 +3
==========================================
+ Hits 2976 2985 +9
+ Misses 350 344 -6 ☔ View full report in Codecov by Sentry. |
marandaneto
reviewed
Sep 5, 2022
4 tasks
marandaneto
approved these changes
Sep 5, 2022
Contributor
|
@denrase there's one broken test. |
bruno-garcia
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Capture and log exceptions thrown in callbacks provided users.
💡 Motivation and Context
All exceptions should be caught and handled gracefully.
Relates to getsentry/team-mobile#21
💚 How did you test it?
Unit tests.
📝 Checklist