Skip to content

flutter min version test#966

Merged
marandaneto merged 22 commits into
mainfrom
chore/flutter-min-version
Jul 28, 2022
Merged

flutter min version test#966
marandaneto merged 22 commits into
mainfrom
chore/flutter-min-version

Conversation

@marandaneto

@marandaneto marandaneto commented Jul 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

📜 Description

TODO: changelog
#skip-changelog

Bump Flutter to min 2.0.0
Add CI step that compiles using Flutter's min. supported version now 2.0.0 and Dart 2.12.0
Fix hashCode issue.
Add dependency for logging and dio so they are compiled against the min. version as well.

💡 Motivation and Context

Fixes #962
Fixes #636

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

github-actions[bot]
github-actions Bot reviewed Jul 27, 2022
View reviewed changes
Comment thread min_version_test/android/app/src/main/kotlin/com/example/min_version_test/MainActivity.kt Outdated
Comment thread min_version_test/android/app/src/main/kotlin/com/example/min_version_test/MainActivity.kt Outdated
Comment thread min_version_test/android/app/src/main/kotlin/com/example/min_version_test/MainActivity.kt Outdated
@codecov-commenter

codecov-commenter commented Jul 27, 2022 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (6750ca1) to head (fc4c7ca).
⚠️ Report is 1464 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
+ Coverage   89.51%   89.55%   +0.04%     
==========================================
  Files         105      106       +1     
  Lines        3308     3322      +14     
==========================================
+ Hits         2961     2975      +14     
  Misses        347      347

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marandaneto

marandaneto commented Jul 27, 2022

Copy link
Copy Markdown
Contributor Author

@ueman found one more issue:

../dart/lib/src/client_reports/client_report_recorder.dart:46:30: Error: Method not found: 'Object.hash'.
  int get hashCode => Object.hash(reason, category);

@marandaneto marandaneto mentioned this pull request Jul 27, 2022
Merged
5 tasks
marandaneto
marandaneto commented Jul 27, 2022
View reviewed changes
Comment thread .github/workflows/min_version_test.yml Outdated
ueman
ueman reviewed Jul 28, 2022
View reviewed changes
Comment thread CHANGELOG.md
brustolin
brustolin approved these changes Jul 28, 2022
View reviewed changes

@brustolin brustolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto
marandaneto marked this pull request as ready for review July 28, 2022 08:00
@marandaneto
marandaneto merged commit ed46e21 into main Jul 28, 2022
@marandaneto
marandaneto deleted the chore/flutter-min-version branch July 28, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia
+2 more reviewers
@ueman ueman ueman left review comments
@brustolin brustolin brustolin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set min. Flutter version to 2.0.0 e2e tests should run on min. supported sdk versions

4 participants

@marandaneto @codecov-commenter @ueman @brustolin