Skip to content

Fix: Breadcrumbs "Concurrent Modification"#948

Merged
marandaneto merged 10 commits into
mainfrom
fix/breadcrumbs-concurrent-modification
Jul 21, 2022
Merged

Fix: Breadcrumbs "Concurrent Modification"#948
marandaneto merged 10 commits into
mainfrom
fix/breadcrumbs-concurrent-modification

Conversation

@denrase

@denrase denrase commented Jul 18, 2022

Copy link
Copy Markdown
Collaborator

📜 Description

Closes #941

💚 How did you test it?

Ran unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

ueman
ueman reviewed Jul 18, 2022
View reviewed changes
Comment thread dart/lib/src/scope.dart Outdated
@codecov-commenter

codecov-commenter commented Jul 19, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #948 (a67dbad) into main (5a35e4a) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   89.81%   89.94%   +0.12%     
==========================================
  Files         104        9      -95     
  Lines        3211      169    -3042     
==========================================
- Hits         2884      152    -2732     
+ Misses        327       17     -310
Impacted Files Coverage Δ
dart/lib/src/scope.dart
dart/lib/src/protocol/sentry_request.dart
dart/lib/src/protocol/sentry_id.dart
dart/lib/src/sentry_envelope.dart
...ib/src/environment/_web_environment_variables.dart
dart/lib/src/protocol/sentry_gpu.dart
...event_processor/deduplication_event_processor.dart
dart/lib/src/protocol/sentry_stack_trace.dart
dart/lib/src/sentry_traces_sampler.dart
dart/lib/src/http_client/tracing_client.dart
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a35e4a...a67dbad. Read the comment docs.

@denrase
denrase marked this pull request as ready for review July 20, 2022 07:33
marandaneto
marandaneto reviewed Jul 20, 2022
View reviewed changes
Comment thread dart/lib/src/scope.dart Outdated
@marandaneto
marandaneto enabled auto-merge (squash) July 21, 2022 06:05
@marandaneto
marandaneto merged commit 5fff088 into main Jul 21, 2022
@marandaneto
marandaneto deleted the fix/breadcrumbs-concurrent-modification branch July 21, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brustolin brustolin Awaiting requested review from brustolin
2 more reviewers
@ueman ueman ueman left review comments
@marandaneto marandaneto marandaneto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Concurrent modification" on ListQueue<Breadcrumb> in 6.6.3

4 participants

@denrase @codecov-commenter @ueman @marandaneto