Skip to content

Scope#setContexts pasing a List value would't not work#932

Merged
marandaneto merged 7 commits into
mainfrom
fix/context-list
Jul 27, 2022
Merged

Scope#setContexts pasing a List value would't not work#932
marandaneto merged 7 commits into
mainfrom
fix/context-list

Conversation

@marandaneto

@marandaneto marandaneto commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

📜 Description

Scope#setContexts pasing a List value would't not work

💡 Motivation and Context

#903

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto
marandaneto requested a review from brustolin as a code owner July 5, 2022 09:07
@marandaneto
marandaneto marked this pull request as draft July 5, 2022 11:26
@marandaneto
marandaneto marked this pull request as ready for review July 26, 2022 13:46
@marandaneto

Copy link
Copy Markdown
Contributor Author

@brustolin ready to be reviewed.

@brustolin brustolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Jul 27, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.51%. Comparing base (53b6921) to head (aadd669).
⚠️ Report is 1483 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
+ Coverage   89.49%   89.51%   +0.01%     
==========================================
  Files         105      105              
  Lines        3303     3308       +5     
==========================================
+ Hits         2956     2961       +5     
  Misses        347      347              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marandaneto
marandaneto merged commit 004b398 into main Jul 27, 2022
@marandaneto
marandaneto deleted the fix/context-list branch July 27, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants