Proof of Concept: Frame Tracking#699
Closed
ueman wants to merge 6 commits into
Closed
Conversation
Contributor
|
@denrase you probably want to check that out since we'd need something similar for the Mobile vitals. |
ueman
commented
Jan 27, 2022
|
|
||
| // postFrameCallbacks are called just once, | ||
| // so we have to add it each frame. | ||
| _binding.addPostFrameCallback(_frameCallback); |
Collaborator
Author
There was a problem hiding this comment.
Maybe a ticker is a better candidate than this? See https://api.flutter.dev/flutter/scheduler/Ticker-class.html
Collaborator
Author
|
This feature was implemented with a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows how one could add the 'total frames' measurement for transactions.
The current code needs some more polishing before it's ready for release.
I'm currently not able to finish this, so I would appreciate it, if someone else would take it over the finishing line.
This also seems to require some (bigger?) changes in the transaction/span API. It's also tricky to get the total frame number with auto closing navigation transaction, because there's no callback.