test(dart): Accept beta wasm function name#3898
Merged
Merged
Conversation
Co-Authored-By: junior <[email protected]> Co-Authored-By: Gino Buenaflor <[email protected]>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Fixes
DependenciesDeps
Internal Changes
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3898 +/- ##
==========================================
- Coverage 87.46% 87.36% -0.11%
==========================================
Files 338 338
Lines 12282 12282
==========================================
- Hits 10743 10730 -13
- Misses 1539 1552 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
buenaflor
approved these changes
Jul 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Dart core SDK browser exception test helper to accept an additional Dart2Wasm mangled function name variant (M.testCaptureException) emitted by Dart beta on Ubuntu, keeping the test stable while preserving stack parsing expectations.
Changes:
- Extends the accepted
topFrame['function']variants for the web/Dart2Wasm Chrome test to includeM.testCaptureException.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4481076 | 1256.48 ms | 1266.64 ms | 10.17 ms |
| 944b773 | 1252.82 ms | 1254.08 ms | 1.27 ms |
| 7b21e8b | 1256.79 ms | 1267.12 ms | 10.33 ms |
| 6ba4675 | 1223.12 ms | 1238.17 ms | 15.04 ms |
| cc4e375 | 1253.06 ms | 1263.81 ms | 10.75 ms |
| 54acf91 | 1257.65 ms | 1277.96 ms | 20.31 ms |
| 79f6b41 | 1269.33 ms | 1279.71 ms | 10.38 ms |
| ea06d23 | 1254.02 ms | 1252.60 ms | -1.42 ms |
| d2356d0 | 1257.04 ms | 1257.94 ms | 0.89 ms |
| e90cf93 | 1235.94 ms | 1246.40 ms | 10.46 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4481076 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 944b773 | 5.53 MiB | 6.00 MiB | 479.98 KiB |
| 7b21e8b | 5.53 MiB | 6.00 MiB | 479.96 KiB |
| 6ba4675 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| cc4e375 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 54acf91 | 20.70 MiB | 22.46 MiB | 1.75 MiB |
| 79f6b41 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| ea06d23 | 5.53 MiB | 5.96 MiB | 443.26 KiB |
| d2356d0 | 5.66 MiB | 6.09 MiB | 448.38 KiB |
| e90cf93 | 5.73 MiB | 6.18 MiB | 463.52 KiB |
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Accept
M.testCaptureExceptionas a valid Dart2Wasm function name in the browser exception test.💡 Motivation and Context
Dart beta now emits this mangled function name on Ubuntu for the Dart2Wasm Chrome test. Stack parsing remains correct; only the expected function-name variants had drifted.
Failing job: https://github.com/getsentry/sentry-dart/actions/runs/29490834029/job/87596299757
💚 How did you test it?
git diff --check📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
Confirm the Ubuntu beta Dart2Wasm job passes in CI.
Requested by Gino Buenaflor via Junior.
--
View Junior Session