chore(skills): Expand test-guidelines and drop stale deps#3807
Merged
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. FeaturesDart
Enhancements
DependenciesDeps
Internal Changes
🤖 This preview updates automatically when you update the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the test-guidelines agent skill documentation to prevent tautological assertions in tests by requiring literal expected values when verifying emitted telemetry/attributes.
Changes:
- Adds an explicit rule in the Assertions section: expected values must be pinned as literals rather than reusing the same production constant being validated.
- Adds a “GOOD vs AVOID” example demonstrating the tautological-assertion pitfall and the preferred pattern.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
buenaflor
changed the title
Document that a test must pin the expected value as a literal rather than the same constant the production code uses to produce it. Sharing one constant across production and test makes the assertion tautological: it passes even when the constant holds the wrong value. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
These were consolidated upstream into pr-writer / skill-writer (already declared), so getsentry/skills no longer exposes them as standalone skills. Their presence made `dotagents install` fail during resolution. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
buenaflor
force-pushed
the
buenaflor/docs/test-guidelines-tautology
branch
2 times, most recently
from
June 30, 2026 12:12
b6f4278 to
051a20e
Compare
buenaflor
changed the title
Test the behavior a change introduces, not the internal guarantee of a shared helper already covered by its own test. Distinguishes a load-bearing contract from a helper's guarantee to avoid discouraging integration tests. Co-Authored-By: Claude Opus 4.8 <[email protected]>
buenaflor
force-pushed
the
buenaflor/docs/test-guidelines-tautology
branch
from
June 30, 2026 12:15
051a20e to
33942c0
Compare
denrase
approved these changes
Jun 30, 2026
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small skill-maintenance changes.
test-guidelinesgains two rules, each with a GOOD/AVOID example:agents.tomldrops two redundant entries —create-prandskill-creator— which are aliases of thepr-writerandskill-writerskills already listed.