Skip to content

feat(feedback): Rename SentryFeedbackWidget to SentryFeedbackForm#3702

Merged
denrase merged 7 commits into
mainfrom
chore/rename-feedback-widget
May 21, 2026
Merged

feat(feedback): Rename SentryFeedbackWidget to SentryFeedbackForm#3702
denrase merged 7 commits into
mainfrom
chore/rename-feedback-widget

Conversation

@denrase

@denrase denrase commented May 18, 2026

Copy link
Copy Markdown
Collaborator

📜 Description

Renames SentryFeedbackWidget to SentryFeedbackForm while keeping a deprecated alias for backward compatibility.

💡 Motivation and Context

Closes #3638

💚 How did you test it?

Run sample app.

Changelog Entry

  • Rename SentryFeedbackWidget to SentryFeedbackForm
    • SentryFeedbackWidget is deprecated and will be removed in the next major version. Use SentryFeedbackForm instead.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

…orm`

Renames SentryFeedbackWidget to SentryFeedbackForm while keeping a deprecated alias for backward compatibility.
@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Features

Feedback

  • Rename SentryFeedbackWidget to SentryFeedbackForm by denrase in #3702
    • SentryFeedbackWidget is deprecated and will be removed in the next major version. Use SentryFeedbackForm instead.
  • Rename SentryFeedbackWidget to SentryFeedbackForm by denrase in #3702
    • SentryFeedbackWidget is deprecated and will be removed in the next major version. Use SentryFeedbackForm instead.

Fixes

Dart

  • Make sentryOnError synchronous in runZonedGuarded by theprantadutta in #3697
  • Route SDK diagnostic logs to browser console on web by theprantadutta in #3698

Flutter

  • Forward sample rate to native SDKs by buenaflor in #3722
  • Release Android JNI refs by buenaflor in #3712
  • Release replay JNI refs by buenaflor in #3699

Enhancements

Flutter

  • Move Android JNI work to core worker to avoid work on main isolate by buenaflor in #3713
  • Optimize Android scope sync by buenaflor in #3708

Dependencies

Deps

  • chore(deps): update Cocoa SDK to v8.58.3 by github-actions in #3726
  • chore(deps): update Android SDK to v8.43.0 by github-actions in #3727

Internal Changes

  • (flutter) Align CI with stable SwiftPM defaults by buenaflor in #3710

🤖 This preview updates automatically when you update the PR.

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.61905% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.91%. Comparing base (79df88f) to head (71537e1).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...flutter/lib/src/feedback/sentry_feedback_form.dart 97.60% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3702      +/-   ##
==========================================
+ Coverage   85.07%   91.91%   +6.83%     
==========================================
  Files         238      105     -133     
  Lines        8485     3737    -4748     
==========================================
- Hits         7219     3435    -3784     
+ Misses       1266      302     -964     
Flag Coverage Δ
sentry ?
sentry_dio ?
sentry_drift ?
sentry_file ?
sentry_firebase_remote_config 100.00% <ø> (ø)
sentry_flutter 91.53% <97.61%> (?)
sentry_hive ?
sentry_isar ?
sentry_link ?
sentry_logging ?
sentry_sqflite ?
sentry_supabase 97.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denrase
denrase marked this pull request as ready for review May 18, 2026 09:36
@denrase
denrase requested a review from buenaflor as a code owner May 18, 2026 09:36
@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 380.11 ms 388.47 ms 8.36 ms
Size 14.55 MiB 15.87 MiB 1.31 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fec56a1 370.66 ms 369.28 ms -1.38 ms
ea06d23 371.10 ms 358.56 ms -12.54 ms
dbd526b 504.88 ms 569.02 ms 64.15 ms
2cf9161 454.12 ms 512.67 ms 58.55 ms
640ad0c 466.00 ms 552.67 ms 86.67 ms
79f6b41 469.66 ms 525.90 ms 56.24 ms
40751bf 421.09 ms 424.82 ms 3.73 ms
13b8895 372.91 ms 370.13 ms -2.79 ms
cba2765 405.98 ms 422.02 ms 16.04 ms
a920b0f 391.75 ms 378.98 ms -12.77 ms

App size

Revision Plain With Sentry Diff
fec56a1 14.31 MiB 15.49 MiB 1.19 MiB
ea06d23 13.93 MiB 15.18 MiB 1.25 MiB
dbd526b 6.54 MiB 7.69 MiB 1.15 MiB
2cf9161 6.54 MiB 7.70 MiB 1.16 MiB
640ad0c 6.54 MiB 7.69 MiB 1.15 MiB
79f6b41 6.54 MiB 7.69 MiB 1.15 MiB
40751bf 14.31 MiB 15.49 MiB 1.19 MiB
13b8895 13.93 MiB 15.18 MiB 1.25 MiB
cba2765 13.93 MiB 15.18 MiB 1.25 MiB
a920b0f 14.09 MiB 15.28 MiB 1.19 MiB

Previous results on branch: chore/rename-feedback-widget

Startup times

Revision Plain With Sentry Diff
e997b4c 369.22 ms 355.04 ms -14.18 ms
503cfb5 383.00 ms 383.56 ms 0.56 ms
e077d9a 361.58 ms 356.12 ms -5.46 ms

App size

Revision Plain With Sentry Diff
e997b4c 14.31 MiB 15.56 MiB 1.25 MiB
503cfb5 14.31 MiB 15.56 MiB 1.25 MiB
e077d9a 14.55 MiB 15.87 MiB 1.31 MiB

@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1245.82 ms 1249.98 ms 4.16 ms
Size 5.83 MiB 6.28 MiB 461.20 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
79df88f 1255.16 ms 1263.51 ms 8.35 ms
765aa8b 1259.09 ms 1269.90 ms 10.82 ms
7cfee3b 1260.90 ms 1273.14 ms 12.24 ms
dc53d48 1252.06 ms 1255.61 ms 3.55 ms
027fcfd 1239.04 ms 1243.65 ms 4.61 ms
584a4b7 1235.62 ms 1233.62 ms -2.00 ms
396cb30 1265.06 ms 1265.73 ms 0.67 ms
e1ab497 1260.92 ms 1260.22 ms -0.69 ms
a920b0f 1254.67 ms 1261.62 ms 6.95 ms
640ad0c 1241.04 ms 1253.96 ms 12.92 ms

App size

Revision Plain With Sentry Diff
79df88f 5.83 MiB 6.28 MiB 461.20 KiB
765aa8b 7.86 MiB 9.44 MiB 1.58 MiB
7cfee3b 20.70 MiB 22.46 MiB 1.75 MiB
dc53d48 5.65 MiB 6.09 MiB 446.96 KiB
027fcfd 5.73 MiB 6.17 MiB 455.48 KiB
584a4b7 5.66 MiB 6.10 MiB 451.31 KiB
396cb30 5.53 MiB 6.01 MiB 488.17 KiB
e1ab497 5.53 MiB 6.01 MiB 487.96 KiB
a920b0f 5.66 MiB 6.10 MiB 453.28 KiB
640ad0c 7.86 MiB 9.44 MiB 1.58 MiB

Previous results on branch: chore/rename-feedback-widget

Startup times

Revision Plain With Sentry Diff
e997b4c 1236.42 ms 1249.63 ms 13.21 ms
503cfb5 1259.53 ms 1258.33 ms -1.21 ms
e077d9a 1243.62 ms 1257.47 ms 13.85 ms

App size

Revision Plain With Sentry Diff
e997b4c 5.73 MiB 6.18 MiB 464.23 KiB
503cfb5 5.73 MiB 6.18 MiB 464.23 KiB
e077d9a 5.83 MiB 6.28 MiB 462.26 KiB

Comment thread packages/flutter/test/feedback/sentry_feedback_widget_test.dart Outdated

@buenaflor buenaflor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, there is a bot review comment, please take a look

Comment thread packages/flutter/test/screenshot/sentry_screenshot_widget_test.dart
Comment thread packages/flutter/test/feedback/sentry_feedback_widget_test.dart Outdated
@denrase
denrase requested a review from buenaflor May 19, 2026 08:57
Comment thread packages/flutter/lib/src/feedback/sentry_feedback_widget.dart

@buenaflor buenaflor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, there are couple failing CI - double check which ones might be caused by this PR

The others I am sure is because SPM is now enabled by default (I'm preparing a PR to fix this)

@denrase
denrase merged commit 9940ffa into main May 21, 2026
71 of 72 checks passed
@denrase
denrase deleted the chore/rename-feedback-widget branch May 21, 2026 14:25
@buenaflor buenaflor changed the title refactor(feedback): Rename SentryFeedbackWidget to SentryFeedbackForm feat(feedback): Rename SentryFeedbackWidget to SentryFeedbackForm May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename SentryFeedbackWidget to SentryFeedbackForm

2 participants