feat(feedback): Rename SentryFeedbackWidget to SentryFeedbackForm#3702
Conversation
…orm` Renames SentryFeedbackWidget to SentryFeedbackForm while keeping a deprecated alias for backward compatibility.
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. FeaturesFeedback
FixesDart
Flutter
EnhancementsFlutter
DependenciesDeps
Internal Changes
🤖 This preview updates automatically when you update the PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3702 +/- ##
==========================================
+ Coverage 85.07% 91.91% +6.83%
==========================================
Files 238 105 -133
Lines 8485 3737 -4748
==========================================
- Hits 7219 3435 -3784
+ Misses 1266 302 -964
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fec56a1 | 370.66 ms | 369.28 ms | -1.38 ms |
| ea06d23 | 371.10 ms | 358.56 ms | -12.54 ms |
| dbd526b | 504.88 ms | 569.02 ms | 64.15 ms |
| 2cf9161 | 454.12 ms | 512.67 ms | 58.55 ms |
| 640ad0c | 466.00 ms | 552.67 ms | 86.67 ms |
| 79f6b41 | 469.66 ms | 525.90 ms | 56.24 ms |
| 40751bf | 421.09 ms | 424.82 ms | 3.73 ms |
| 13b8895 | 372.91 ms | 370.13 ms | -2.79 ms |
| cba2765 | 405.98 ms | 422.02 ms | 16.04 ms |
| a920b0f | 391.75 ms | 378.98 ms | -12.77 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fec56a1 | 14.31 MiB | 15.49 MiB | 1.19 MiB |
| ea06d23 | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| dbd526b | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 2cf9161 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 640ad0c | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 79f6b41 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 40751bf | 14.31 MiB | 15.49 MiB | 1.19 MiB |
| 13b8895 | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| cba2765 | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| a920b0f | 14.09 MiB | 15.28 MiB | 1.19 MiB |
Previous results on branch: chore/rename-feedback-widget
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e997b4c | 369.22 ms | 355.04 ms | -14.18 ms |
| 503cfb5 | 383.00 ms | 383.56 ms | 0.56 ms |
| e077d9a | 361.58 ms | 356.12 ms | -5.46 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e997b4c | 14.31 MiB | 15.56 MiB | 1.25 MiB |
| 503cfb5 | 14.31 MiB | 15.56 MiB | 1.25 MiB |
| e077d9a | 14.55 MiB | 15.87 MiB | 1.31 MiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 79df88f | 1255.16 ms | 1263.51 ms | 8.35 ms |
| 765aa8b | 1259.09 ms | 1269.90 ms | 10.82 ms |
| 7cfee3b | 1260.90 ms | 1273.14 ms | 12.24 ms |
| dc53d48 | 1252.06 ms | 1255.61 ms | 3.55 ms |
| 027fcfd | 1239.04 ms | 1243.65 ms | 4.61 ms |
| 584a4b7 | 1235.62 ms | 1233.62 ms | -2.00 ms |
| 396cb30 | 1265.06 ms | 1265.73 ms | 0.67 ms |
| e1ab497 | 1260.92 ms | 1260.22 ms | -0.69 ms |
| a920b0f | 1254.67 ms | 1261.62 ms | 6.95 ms |
| 640ad0c | 1241.04 ms | 1253.96 ms | 12.92 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 79df88f | 5.83 MiB | 6.28 MiB | 461.20 KiB |
| 765aa8b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 7cfee3b | 20.70 MiB | 22.46 MiB | 1.75 MiB |
| dc53d48 | 5.65 MiB | 6.09 MiB | 446.96 KiB |
| 027fcfd | 5.73 MiB | 6.17 MiB | 455.48 KiB |
| 584a4b7 | 5.66 MiB | 6.10 MiB | 451.31 KiB |
| 396cb30 | 5.53 MiB | 6.01 MiB | 488.17 KiB |
| e1ab497 | 5.53 MiB | 6.01 MiB | 487.96 KiB |
| a920b0f | 5.66 MiB | 6.10 MiB | 453.28 KiB |
| 640ad0c | 7.86 MiB | 9.44 MiB | 1.58 MiB |
Previous results on branch: chore/rename-feedback-widget
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e997b4c | 1236.42 ms | 1249.63 ms | 13.21 ms |
| 503cfb5 | 1259.53 ms | 1258.33 ms | -1.21 ms |
| e077d9a | 1243.62 ms | 1257.47 ms | 13.85 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e997b4c | 5.73 MiB | 6.18 MiB | 464.23 KiB |
| 503cfb5 | 5.73 MiB | 6.18 MiB | 464.23 KiB |
| e077d9a | 5.83 MiB | 6.28 MiB | 462.26 KiB |
buenaflor
left a comment
There was a problem hiding this comment.
looks good, there is a bot review comment, please take a look
buenaflor
left a comment
There was a problem hiding this comment.
lgtm, there are couple failing CI - double check which ones might be caused by this PR
The others I am sure is because SPM is now enabled by default (I'm preparing a PR to fix this)
SentryFeedbackWidget to SentryFeedbackFormSentryFeedbackWidget to SentryFeedbackForm
📜 Description
Renames SentryFeedbackWidget to SentryFeedbackForm while keeping a deprecated alias for backward compatibility.
💡 Motivation and Context
Closes #3638
💚 How did you test it?
Run sample app.
Changelog Entry
SentryFeedbackWidgettoSentryFeedbackFormSentryFeedbackWidgetis deprecated and will be removed in the next major version. UseSentryFeedbackForminstead.📝 Checklist
sendDefaultPiiis enabled