build: Remove collection runtime dependency by buenaflor · Pull Request #3680 · getsentry/sentry-dart

buenaflor · 2026-04-30T13:40:43Z

📜 Description

Removes collection from runtime dependencies in sentry, sentry_flutter, and _sentry_testing by replacing production nullable iterable lookups with a small SentryIterableUtils extension in the core SDK.

collection remains available as a dev dependency where tests still use its equality helpers.

💡 Motivation and Context

Production code only relied on firstOrNull and firstWhereOrNull, so shipping the full collection package for runtime use is unnecessary. Keeping those helpers in the core SDK avoids an extra runtime dependency while preserving existing behavior.

💚 How did you test it?

fvm dart analyze on changed Dart SDK files
fvm flutter analyze on changed Flutter SDK files
fvm dart analyze in _sentry_testing
fvm dart test test/utils/iterable_utils_test.dart test/sentry_event_test.dart test/event_processor/exception/io_exception_event_processor_test.dart test/sentry_test.dart
fvm flutter test test/integrations/load_contexts_integration_test.dart test/navigation/time_to_display_tracker_test.dart test/navigation/sentry_navigator_observer_test.dart test/feedback/sentry_feedback_widget_test.dart
pre-commit analyze hooks

Closes #3679

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

None.

Made with Cursor

Move nullable iterable helpers into the core SDK and keep collection only for test code that still relies on its equality helpers. Co-Authored-By: GPT-5.5 <[email protected]> Made-with: Cursor

github-actions · 2026-04-30T13:41:01Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

Features

(span-first) Add transaction and app start type span attributes by buenaflor in #3678
Prevent cross-organization trace continuation by antonis in #3567
- By default, the SDK now extracts the organization ID from the DSN (e.g. o123.ingest.sentry.io) and compares it with the sentry-org_id value in incoming baggage headers. When the two differ, the SDK starts a fresh trace instead of continuing the foreign one. This guards against accidentally linking traces across organizations.
- New option strictTraceContinuation (default false): when enabled, both the SDK's org ID and the incoming baggage org ID must be present and match for a trace to be continued. Traces with a missing org ID on either side are rejected.
- New option orgId: allows explicitly setting the organization ID for self-hosted and Relay setups where it cannot be extracted from the DSN.
- Options are also applied to the native Android SDK. On iOS, only the Dart layer enforces strict trace continuation.

Fixes

Flutter

Avoid JNI callbacks for Android scope sync by denrase in #3676
Send frame delay in seconds by buenaflor in #3677

Dependencies

Deps

chore(deps): update Cocoa SDK to v8.58.2 by github-actions in #3664
chore(deps): update Native SDK to v0.13.8 by github-actions in #3667
chore(deps): update Android SDK to v8.40.0 by github-actions in #3663

Internal Changes

Remove collection runtime dependency by buenaflor in #3680

Remove collection runtime dependency by buenaflor in #3680
Notify linked issues on release by buenaflor in #3685
Enforce conventional commit format for PR titles by buenaflor in #3666

_{🤖 This preview updates automatically when you update the PR.}

codecov · 2026-04-30T13:41:53Z

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.84%. Comparing base (75cbd63) to head (930c4e3).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ckages/flutter/lib/src/native/c/sentry_native.dart	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3680      +/-   ##
==========================================
- Coverage   86.84%   86.84%   -0.01%     
==========================================
  Files         335      335              
  Lines       11969    11976       +7     
==========================================
+ Hits        10394    10400       +6     
- Misses       1575     1576       +1

Flag	Coverage Δ
sentry	`86.73% <100.00%> (+<0.01%)`	⬆️
sentry_dio	`97.73% <ø> (ø)`
sentry_drift	`93.57% <ø> (ø)`
sentry_file	`65.29% <ø> (ø)`
sentry_firebase_remote_config	`100.00% <ø> (ø)`
sentry_flutter	`91.15% <80.00%> (-0.02%)`	⬇️
sentry_hive	`77.48% <ø> (ø)`
sentry_isar	`74.37% <ø> (ø)`
sentry_link	`21.50% <ø> (ø)`
sentry_logging	`97.01% <ø> (ø)`
sentry_sqflite	`88.81% <ø> (ø)`
sentry_supabase	`97.27% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Expose the nullable iterable extension through the core SDK barrel so Flutter can consume it the same way it consumes other internal SDK types. Co-Authored-By: GPT-5.5 <[email protected]> Made-with: Cursor

github-actions · 2026-04-30T13:51:56Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1260.09 ms	1256.00 ms	-4.09 ms
Size	5.73 MiB	6.18 MiB	463.48 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`dc53d48`	1252.06 ms	1255.61 ms	3.55 ms
`2cb90b9`	1272.90 ms	1285.55 ms	12.66 ms
`c26ed0a`	1244.11 ms	1263.85 ms	19.75 ms
`f579250`	1248.14 ms	1250.15 ms	2.01 ms
`396cb30`	1265.06 ms	1265.73 ms	0.67 ms
`0fb3800`	1256.60 ms	1266.28 ms	9.68 ms
`57eccdf`	1247.91 ms	1252.76 ms	4.84 ms
`6f47800`	1247.52 ms	1259.37 ms	11.85 ms
`0fb45d0`	1273.24 ms	1286.44 ms	13.19 ms
`73a3c38`	1263.37 ms	1277.90 ms	14.53 ms

App size

Revision	Plain	With Sentry	Diff
`dc53d48`	5.65 MiB	6.09 MiB	446.96 KiB
`2cb90b9`	7.86 MiB	9.54 MiB	1.69 MiB
`c26ed0a`	5.53 MiB	5.97 MiB	453.76 KiB
`f579250`	5.66 MiB	6.09 MiB	448.36 KiB
`396cb30`	5.53 MiB	6.01 MiB	488.17 KiB
`0fb3800`	7.86 MiB	9.44 MiB	1.58 MiB
`57eccdf`	5.73 MiB	6.17 MiB	453.80 KiB
`6f47800`	7.86 MiB	9.44 MiB	1.58 MiB
`0fb45d0`	7.86 MiB	9.44 MiB	1.58 MiB
`73a3c38`	7.86 MiB	9.44 MiB	1.58 MiB

Previous results on branch: buenaflor/chore/remove-collection-dependency

Startup times

Revision	Plain	With Sentry	Diff
`5fff246`	1248.55 ms	1253.00 ms	4.45 ms
`fe38858`	1246.36 ms	1248.63 ms	2.27 ms
`1178cd1`	1240.13 ms	1244.35 ms	4.22 ms
`597d219`	1235.94 ms	1244.93 ms	8.99 ms

App size

Revision	Plain	With Sentry	Diff
`5fff246`	5.73 MiB	6.18 MiB	463.45 KiB
`fe38858`	5.73 MiB	6.18 MiB	463.46 KiB
`1178cd1`	5.73 MiB	6.18 MiB	463.91 KiB
`597d219`	5.73 MiB	6.18 MiB	463.46 KiB

github-actions · 2026-04-30T14:00:11Z

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	372.77 ms	366.81 ms	-5.96 ms
Size	14.31 MiB	15.56 MiB	1.25 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`8541716`	437.14 ms	443.65 ms	6.51 ms
`4e14113`	361.52 ms	353.19 ms	-8.33 ms
`af96ef2`	375.84 ms	382.02 ms	6.18 ms
`aaa2730`	354.04 ms	370.46 ms	16.41 ms
`cfca825`	417.36 ms	393.37 ms	-23.99 ms
`29e8ebe`	389.91 ms	395.76 ms	5.84 ms
`c5cf749`	379.18 ms	360.60 ms	-18.58 ms
`0fb3800`	465.64 ms	536.77 ms	71.13 ms
`aeb02f2`	373.84 ms	437.00 ms	63.16 ms
`d789735`	363.95 ms	358.09 ms	-5.87 ms

App size

Revision	Plain	With Sentry	Diff
`8541716`	13.93 MiB	15.00 MiB	1.06 MiB
`4e14113`	14.09 MiB	15.28 MiB	1.19 MiB
`af96ef2`	13.93 MiB	15.18 MiB	1.25 MiB
`aaa2730`	14.31 MiB	15.49 MiB	1.19 MiB
`cfca825`	14.09 MiB	15.28 MiB	1.19 MiB
`29e8ebe`	13.93 MiB	15.06 MiB	1.13 MiB
`c5cf749`	14.31 MiB	15.49 MiB	1.19 MiB
`0fb3800`	6.54 MiB	7.69 MiB	1.15 MiB
`aeb02f2`	6.54 MiB	7.69 MiB	1.15 MiB
`d789735`	13.93 MiB	15.18 MiB	1.25 MiB

Previous results on branch: buenaflor/chore/remove-collection-dependency

Startup times

Revision	Plain	With Sentry	Diff
`1178cd1`	374.83 ms	360.13 ms	-14.70 ms
`fe38858`	435.76 ms	455.68 ms	19.92 ms
`5fff246`	382.45 ms	370.06 ms	-12.38 ms
`597d219`	388.30 ms	371.53 ms	-16.77 ms

App size

Revision	Plain	With Sentry	Diff
`1178cd1`	14.31 MiB	15.56 MiB	1.25 MiB
`fe38858`	14.31 MiB	15.56 MiB	1.25 MiB
`5fff246`	14.31 MiB	15.56 MiB	1.25 MiB
`597d219`	14.31 MiB	15.56 MiB	1.25 MiB

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Keep iterable utilities scoped to non-null iterables so nullable call sites continue to show explicit null-aware access. Co-Authored-By: GPT-5.5 <[email protected]> Co-authored-by: Cursor <[email protected]>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 2556a89. Configure here.}

Use explicit static iterable helpers so exported Sentry APIs do not add extension members that can conflict with Dart collection extensions. Co-Authored-By: GPT-5.5 <[email protected]> Co-authored-by: Cursor <[email protected]>

Annotate the static iterable helper as internal so consumers get the intended lint signal even though it is exported for package use. Co-Authored-By: GPT-5.5 <[email protected]> Co-authored-by: Cursor <[email protected]>

Avoid exporting Iterable extension helpers from the public SDK barrel. Sibling packages import the internal helper directly to keep user extension resolution unaffected. Co-Authored-By: GPT-5.5 <[email protected]> Co-authored-by: Cursor <[email protected]>

build: Remove collection runtime dependency

fe38858

Move nullable iterable helpers into the core SDK and keep collection only for test code that still relies on its equality helpers. Co-Authored-By: GPT-5.5 <[email protected]> Made-with: Cursor

Copilot AI review requested due to automatic review settings April 30, 2026 13:40

buenaflor requested a review from denrase as a code owner April 30, 2026 13:40

Copilot started reviewing on behalf of buenaflor April 30, 2026 13:41 View session

sentry-warden Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/feedback/sentry_feedback_widget.dart

ref: Export internal iterable utilities

597d219

Expose the nullable iterable extension through the core SDK barrel so Flutter can consume it the same way it consumes other internal SDK types. Co-Authored-By: GPT-5.5 <[email protected]> Made-with: Cursor

sentry-warden Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/event_processor/android_platform_exception_event_processor.dart Outdated

Copilot AI reviewed Apr 30, 2026

Merge branch 'main' into buenaflor/chore/remove-collection-dependency

5fff246

denrase requested changes May 4, 2026

View reviewed changes

Comment thread packages/dart/lib/src/utils/iterable_utils.dart Outdated

Comment thread packages/dart/lib/src/utils/iterable_utils.dart

fix: Preserve nullable iterable access

2556a89

Keep iterable utilities scoped to non-null iterables so nullable call sites continue to show explicit null-aware access. Co-Authored-By: GPT-5.5 <[email protected]> Co-authored-by: Cursor <[email protected]>

cursor Bot reviewed May 4, 2026

View reviewed changes

Comment thread packages/dart/lib/sentry.dart Outdated

fix: Avoid iterable extension conflicts

1178cd1

Use explicit static iterable helpers so exported Sentry APIs do not add extension members that can conflict with Dart collection extensions. Co-Authored-By: GPT-5.5 <[email protected]> Co-authored-by: Cursor <[email protected]>

buenaflor requested a review from denrase May 4, 2026 17:37

fix: Mark iterable utils internal

ff49ee4

Annotate the static iterable helper as internal so consumers get the intended lint signal even though it is exported for package use. Co-Authored-By: GPT-5.5 <[email protected]> Co-authored-by: Cursor <[email protected]>

denrase approved these changes May 5, 2026

View reviewed changes

buenaflor merged commit 425566c into main May 5, 2026
169 of 170 checks passed

buenaflor deleted the buenaflor/chore/remove-collection-dependency branch May 5, 2026 11:58

This was referenced May 5, 2026

publish: getsentry/[email protected] getsentry/publish#8089

Closed

publish: getsentry/[email protected] getsentry/publish#8116

Closed

github-actions Bot mentioned this pull request May 7, 2026

Remove collection dependency #3679

Closed

Uh oh!

Uh oh!

Conversation

buenaflor commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Features

Fixes

Flutter

Dependencies

Deps

Internal Changes

Uh oh!

codecov Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: buenaflor/chore/remove-collection-dependency

Startup times

App size

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: buenaflor/chore/remove-collection-dependency

Startup times

App size

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

buenaflor commented Apr 30, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading

codecov Bot commented Apr 30, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading