build(flutter-example): Fix macOS SPM build and bump AGP to 8.6.0#3644
Conversation
Flutter beta (3.44) enables SwiftPM by default, causing the build job to fail on macOS with a package identity mismatch. Apply the same directory rename workaround already used in the spm job. Also bump Android Gradle Plugin from 8.2.2 to 8.6.0 to meet Flutter's new minimum requirement. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3644 +/- ##
==========================================
+ Coverage 86.94% 91.80% +4.85%
==========================================
Files 320 102 -218
Lines 10789 3479 -7310
==========================================
- Hits 9381 3194 -6187
+ Misses 1408 285 -1123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
Updates Flutter CI and the Android example configuration to keep builds working with Flutter beta’s SwiftPM defaults and updated Android tooling requirements.
Changes:
- Apply the SwiftPM package directory rename workaround to the
buildjob for macOS targets. - Adjust the macOS example build working directory accordingly.
- Bump Android Gradle Plugin to 8.6.0 in the Flutter example app.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/flutter.yml |
Renames packages/flutter to packages/sentry_flutter for macOS build targets and updates the example build path to avoid SwiftPM identity mismatch failures. |
packages/flutter/example/android/settings.gradle |
Updates com.android.application (AGP) plugin version to 8.6.0 to satisfy Flutter beta requirements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📲 Install BuildsAndroid
|
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4298701 | 524.40 ms | 633.30 ms | 108.90 ms |
| e200a70 | 433.06 ms | 437.00 ms | 3.94 ms |
| ec78888 | 457.94 ms | 519.96 ms | 62.02 ms |
| af96ef2 | 375.84 ms | 382.02 ms | 6.18 ms |
| 79f6b41 | 469.66 ms | 525.90 ms | 56.24 ms |
| 3615e19 | 468.38 ms | 504.71 ms | 36.33 ms |
| 0265ce5 | 406.39 ms | 418.48 ms | 12.09 ms |
| 9b99523 | 456.91 ms | 490.55 ms | 33.64 ms |
| c97f488 | 502.43 ms | 492.47 ms | -9.97 ms |
| 67de70c | 375.88 ms | 356.11 ms | -19.77 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4298701 | 6.54 MiB | 7.71 MiB | 1.17 MiB |
| e200a70 | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| ec78888 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| af96ef2 | 13.93 MiB | 15.18 MiB | 1.25 MiB |
| 79f6b41 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 3615e19 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 0265ce5 | 14.09 MiB | 15.28 MiB | 1.19 MiB |
| 9b99523 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| c97f488 | 14.31 MiB | 15.49 MiB | 1.19 MiB |
| 67de70c | 14.31 MiB | 15.49 MiB | 1.19 MiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 55b7a00 | 1279.45 ms | 1274.58 ms | -4.87 ms |
| 0fb45d0 | 1273.24 ms | 1286.44 ms | 13.19 ms |
| e0c8591 | 1259.85 ms | 1257.31 ms | -2.54 ms |
| f3771ea | 1258.53 ms | 1255.22 ms | -3.32 ms |
| f761369 | 1261.69 ms | 1277.82 ms | 16.12 ms |
| fec56a1 | 1251.71 ms | 1241.31 ms | -10.40 ms |
| af96ef2 | 1260.79 ms | 1259.61 ms | -1.17 ms |
| b4b7781 | 1239.98 ms | 1245.67 ms | 5.69 ms |
| c26ed0a | 1244.11 ms | 1263.85 ms | 19.75 ms |
| c8596a6 | 1234.11 ms | 1241.19 ms | 7.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 55b7a00 | 5.73 MiB | 6.17 MiB | 453.79 KiB |
| 0fb45d0 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| e0c8591 | 5.53 MiB | 5.96 MiB | 444.86 KiB |
| f3771ea | 5.73 MiB | 6.17 MiB | 455.44 KiB |
| f761369 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| fec56a1 | 5.73 MiB | 6.17 MiB | 455.53 KiB |
| af96ef2 | 5.53 MiB | 6.02 MiB | 501.31 KiB |
| b4b7781 | 5.73 MiB | 6.17 MiB | 455.48 KiB |
| c26ed0a | 5.53 MiB | 5.97 MiB | 453.76 KiB |
| c8596a6 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
denrase
left a comment
There was a problem hiding this comment.
workaround all the things \o/
📜 Description
buildjob for macOS targets (was only in thespmjob)💡 Motivation and Context
Flutter beta (3.44) enables SwiftPM by default, causing the
buildjob's macOS example build to fail with:The
spmjob already had the rename workaround (from #3640), but thebuildjob didn't. Also, Flutter beta now requires AGP >= 8.6.0.💚 How did you test it?
CI
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps