[DRAFT] feat(span-first): Span Buffer#3396
Closed
buenaflor wants to merge 6 commits into
Closed
Conversation
…to use new buffers, update captureSpan method, and enhance SimpleSpan serialization.
… logs and spans, update InMemoryTelemetryBuffer to utilize flusher, and streamline SentryClient initialization for telemetry buffers.
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Span Buffer ([#3396](https://github.com/getsentry/sentry-dart/pull/3396))If none of the above apply, you can opt out of this check by adding |
… and segmentKey methods to Span and its subclasses. Update NoOpSpan, SimpleSpan, and UnsetSpan to implement these methods, improving span management and telemetry context handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR is still WIP
Note that the proposed architecture is not yet final - the full spec is still WIP and this is only a minimal part of it.
This current impl does not include:
💡 Motivation and Context
New Telemetry Buffer Architecture
Note that this only illustrates mainly the default
InMemoryTelemetryBufferbut it is later swappable when we will eventually reuse iOS and Android (crash-safe) native buffers(graphics made by Cursor :D)
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps