enh: refactor `init` to use JNI/FFI by buenaflor · Pull Request #3324 · getsentry/sentry-dart

buenaflor · 2025-11-06T16:17:26Z

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2025-11-06T16:18:06Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

github-actions · 2025-11-06T16:31:15Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1260.88 ms	1266.24 ms	5.37 ms
Size	5.53 MiB	6.02 MiB	502.02 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`819c1e7`	1250.59 ms	1249.08 ms	-1.51 ms
`765aa8b`	1259.09 ms	1269.90 ms	10.82 ms
`ad121c0`	1275.04 ms	1280.59 ms	5.55 ms
`de377fd`	1252.28 ms	1254.76 ms	2.48 ms
`192b44c`	1269.08 ms	1275.52 ms	6.44 ms
`e1ab497`	1260.92 ms	1260.22 ms	-0.69 ms
`6ad8fc4`	1263.70 ms	1266.06 ms	2.36 ms
`5b9a0da`	1249.69 ms	1250.71 ms	1.03 ms
`c0dde50`	1268.90 ms	1275.61 ms	6.71 ms
`6bcdc99`	1257.16 ms	1264.96 ms	7.79 ms

App size

Revision	Plain	With Sentry	Diff
`819c1e7`	5.53 MiB	6.00 MiB	479.96 KiB
`765aa8b`	7.86 MiB	9.44 MiB	1.58 MiB
`ad121c0`	5.53 MiB	6.01 MiB	488.11 KiB
`de377fd`	20.71 MiB	22.43 MiB	1.73 MiB
`192b44c`	5.53 MiB	5.96 MiB	444.33 KiB
`e1ab497`	5.53 MiB	6.01 MiB	487.96 KiB
`6ad8fc4`	5.53 MiB	6.01 MiB	487.65 KiB
`5b9a0da`	5.53 MiB	5.96 MiB	444.32 KiB
`c0dde50`	5.53 MiB	6.01 MiB	488.14 KiB
`6bcdc99`	5.53 MiB	6.00 MiB	479.95 KiB

Previous results on branch: enh/ffi-jni-init

Startup times

Revision	Plain	With Sentry	Diff
`1f506d7`	1255.16 ms	1253.69 ms	-1.48 ms
`48149f1`	1240.53 ms	1252.12 ms	11.59 ms
`89fb6c2`	1250.77 ms	1255.64 ms	4.87 ms
`37f0c51`	1250.10 ms	1248.25 ms	-1.85 ms
`0f928f6`	1247.59 ms	1255.63 ms	8.04 ms
`21cac57`	1259.12 ms	1269.06 ms	9.94 ms
`ab4c77e`	1267.45 ms	1275.17 ms	7.71 ms

App size

Revision	Plain	With Sentry	Diff
`1f506d7`	5.53 MiB	6.02 MiB	501.99 KiB
`48149f1`	5.53 MiB	6.02 MiB	502.03 KiB
`89fb6c2`	5.53 MiB	6.02 MiB	502.04 KiB
`37f0c51`	5.53 MiB	6.02 MiB	502.02 KiB
`0f928f6`	5.53 MiB	6.02 MiB	502.02 KiB
`21cac57`	5.53 MiB	6.02 MiB	501.98 KiB
`ab4c77e`	5.53 MiB	6.02 MiB	502.31 KiB

buenaflor · 2025-11-11T13:36:31Z

 final ObjCObjectBase Function(Object) _defaultObjcConverter = (obj) {
  return switch (obj) {
-    bool b => b ? 1.toNSNumber() : 0.toNSNumber(),
+    bool b => NSNumberCreation.numberWithBool(b),


previous convert was wrong, it should've been using NSNumberCreation

cursor

Bug: Performance Tracking Ignores Disabled State

The autoPerformanceTracingEnabled check was removed from fetchNativeAppStartAsBytes, meaning app start metrics are now returned even when auto performance tracing is disabled. This changes behavior from the previous implementation where the function would return null early when autoPerformanceTracingEnabled was false, potentially causing unwanted performance tracking.

packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt#L185-L196

sentry-dart/packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

Lines 185 to 196 in d31f1a9

    
           @JvmStatic 
        
           fun fetchNativeAppStartAsBytes(): ByteArray? { 
        
             val appStartMetrics = AppStartMetrics.getInstance() 
        
             if (!appStartMetrics.isAppLaunchedInForeground || 
        
               appStartMetrics.appStartTimeSpan.durationMs > APP_START_MAX_DURATION_MS 
        
             ) { 
        
               Log.w( 
        
                 "Sentry", 
        
                 "Invalid app start data: app not launched in foreground or app start took too long (>60s)", 
        
               ) 
        
               return null

The v10 feature work pushed the with-Sentry APK size diff to ~1409 KiB, past the 1350 KiB budget, failing the SDK metrics job on v10-branch and every PR based on it. Raise diffMax to 1450 KiB, following the same pattern as #3324 and #3567. Co-Authored-By: Claude Fable 5 <[email protected]>

@deprecated

* ref!: Make clone() internal; drop protocol clones clone() on Hub, Scope, NoOpHub, HubAdapter and Sentry is intended for SDK-internal use only, so mark it @internal. The protocol clone() methods (Contexts and its children) were already @deprecated and formed a dead subtree with no remaining callers, so remove them along with the alias-only clone context test. BREAKING CHANGE: The deprecated clone() on protocol classes is removed, and clone() on Hub/Scope is now @internal. Fixes GH-3824 Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> * ref: Rename feature flag copy() to clone() Align internal naming with Hub.clone() and Scope.clone(). The copy name existed only to avoid clashing with the deprecated public clone() API, which this branch removes. Co-Authored-By: Claude Fable 5 <[email protected]> * test(flutter): Fix OnProcessSpan calls missing Hint PR #3847 added a required hint parameter to OnProcessSpan but missed the five call sites in thread_info_integration_test.dart, which landed in parallel. This breaks compilation of the flutter test suite and the analyze gate on v10-branch, failing CI for every PR based on it. Co-Authored-By: Claude Fable 5 <[email protected]> * chore(metrics): Raise Android binary size budget The v10 feature work pushed the with-Sentry APK size diff to ~1409 KiB, past the 1350 KiB budget, failing the SDK metrics job on v10-branch and every PR based on it. Raise diffMax to 1450 KiB, following the same pattern as #3324 and #3567. Co-Authored-By: Claude Fable 5 <[email protected]> --------- Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>

buenaflor added 4 commits November 6, 2025 14:36

Android side

e53fa94

Update

2748859

Update

6033ea8

Update

b864cf0

buenaflor added 12 commits November 7, 2025 21:03

Simple ios ffi gen

cb9f451

Fix compilation

0f1a611

Update

23d49da

Update

3e15e01

Remove method channel

36491eb

Remove unnecessary code

256ad72

Update

561d56e

Update

89079ed

Update

1dab36d

Update

d7fe123

newlines

747c4c3

newlines

b8d8378

buenaflor commented Nov 11, 2025

View reviewed changes

Comment thread packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

buenaflor added 4 commits November 11, 2025 14:31

Update

9d18550

Update

444175e

Update

7264607

Update

63bb590

buenaflor commented Nov 11, 2025

View reviewed changes

Comment thread packages/flutter/example/lib/main.dart

Update

a968e32

buenaflor commented Nov 11, 2025

View reviewed changes

buenaflor changed the title ~~(DRAFT) enh: refactor init to use JNI/FFI~~ enh: refactor init to use JNI/FFI Nov 11, 2025

buenaflor and others added 3 commits November 11, 2025 14:38

Merge branch 'main' into enh/ffi-jni-init

1d807c3

Remove macos symlink to SentryFlutter.swift

48fdf3a

remove old files

831e2aa

buenaflor and others added 2 commits November 14, 2025 12:56

Try fix long running web integration test

9808a56

Merge branch 'main' into enh/ffi-jni-init

fd0aa08

buenaflor marked this pull request as ready for review November 14, 2025 11:57

buenaflor requested a review from stefanosiano as a code owner November 14, 2025 11:57

sentry Bot reviewed Nov 14, 2025

View reviewed changes

Comment thread packages/flutter/lib/src/native/java/sentry_native_java_init.dart

buenaflor added 2 commits November 14, 2025 13:08

Fix memory leak

37f0c51

Update CI

d31f1a9

cursor Bot reviewed Nov 14, 2025

View reviewed changes

Comment thread ...utter/ios/sentry_flutter/Sources/sentry_flutter_objc/SentryFlutterReplayScreenshotProvider.m

buenaflor and others added 4 commits November 14, 2025 14:24

Merge branch 'main' into enh/ffi-jni-init

89fb6c2

Update CI

6f4ec41

Update CI

1fa231b

Update CI

fd0ba85

cursor Bot reviewed Nov 14, 2025

View reviewed changes

Comment thread packages/flutter/example/lib/main.dart

Update CI

0a54877

cursor Bot reviewed Nov 14, 2025

View reviewed changes

Comment thread packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

Comment thread packages/flutter/example/integration_test/integration_test.dart

buenaflor added 5 commits November 14, 2025 14:49

Update comments

ef9f743

Update CI

13237cf

Update CI

3807f78

Update CI

ead9a05

Update CI

0bb46ef

cursor Bot reviewed Nov 17, 2025

View reviewed changes

Comment thread packages/flutter/example/lib/main.dart

buenaflor added 2 commits November 17, 2025 11:08

Update CI

f96f0e5

Update CI

1866d6b

cursor Bot reviewed Nov 17, 2025

View reviewed changes

Comment thread packages/flutter/example/lib/main.dart

buenaflor merged commit d0aa4b6 into main Nov 17, 2025
137 checks passed

buenaflor deleted the enh/ffi-jni-init branch November 17, 2025 10:30

Kobby-Bawuah mentioned this pull request May 27, 2026

sampleRate is not forwarded from Dart to native SDKs on iOS and Android, native crashes/hangs/watchdogs sampled at 100% regardless of options.sampleRate #3720

Closed

buenaflor mentioned this pull request Jul 6, 2026

ref: Make clone() internal and remove deprecated protocol clones #3845

Merged

	@JvmStatic
	fun fetchNativeAppStartAsBytes(): ByteArray? {
	val appStartMetrics = AppStartMetrics.getInstance()

	if (!appStartMetrics.isAppLaunchedInForeground \|\|
	appStartMetrics.appStartTimeSpan.durationMs > APP_START_MAX_DURATION_MS
	) {
	Log.w(
	"Sentry",
	"Invalid app start data: app not launched in foreground or app start took too long (>60s)",
	)
	return null

Uh oh!

Uh oh!

Conversation

buenaflor commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions Bot commented Nov 6, 2025 • edited by buenaflor Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions Bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: enh/ffi-jni-init

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

buenaflor Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Bug: Performance Tracking Ignores Disabled State

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

buenaflor commented Nov 6, 2025 •

edited

Loading

github-actions Bot commented Nov 6, 2025 •

edited by buenaflor

Loading

github-actions Bot commented Nov 6, 2025 •

edited

Loading