enh: refactor `captureReplay` and `setReplayConfig` to use FFI/JNI by buenaflor · Pull Request #3318 · getsentry/sentry-dart

buenaflor · 2025-10-31T10:18:13Z

📜 Description

Part of moving away from method channels

💡 Motivation and Context

Closes #3209

💚 How did you test it?

Manual but will need to check if it's possible to test this with integration tests in some way

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2025-10-31T10:18:31Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

github-actions · 2025-10-31T10:27:15Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1245.06 ms	1240.21 ms	-4.86 ms
Size	5.53 MiB	6.01 MiB	488.12 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`827bf09`	1261.86 ms	1276.41 ms	14.55 ms
`192b44c`	1269.08 ms	1275.52 ms	6.44 ms
`5a95d04`	1263.17 ms	1265.37 ms	2.20 ms
`1f639ee`	1252.43 ms	1257.82 ms	5.38 ms
`819c1e7`	1250.59 ms	1249.08 ms	-1.51 ms
`c8596a6`	1234.11 ms	1241.19 ms	7.08 ms
`6ad8fc4`	1263.70 ms	1266.06 ms	2.36 ms
`c1e775e`	1263.08 ms	1275.32 ms	12.24 ms
`54acf91`	1257.65 ms	1277.96 ms	20.31 ms
`7b21e8b`	1256.79 ms	1267.12 ms	10.33 ms

App size

Revision	Plain	With Sentry	Diff
`827bf09`	7.86 MiB	9.44 MiB	1.58 MiB
`192b44c`	5.53 MiB	5.96 MiB	444.33 KiB
`5a95d04`	5.53 MiB	6.01 MiB	487.81 KiB
`1f639ee`	5.53 MiB	6.00 MiB	479.95 KiB
`819c1e7`	5.53 MiB	6.00 MiB	479.96 KiB
`c8596a6`	7.86 MiB	9.44 MiB	1.58 MiB
`6ad8fc4`	5.53 MiB	6.01 MiB	487.65 KiB
`c1e775e`	20.70 MiB	22.46 MiB	1.75 MiB
`54acf91`	20.70 MiB	22.46 MiB	1.75 MiB
`7b21e8b`	5.53 MiB	6.00 MiB	479.96 KiB

Previous results on branch: enh/ffi-jni-replay-config

Startup times

Revision	Plain	With Sentry	Diff
`9da5e55`	1268.88 ms	1269.67 ms	0.80 ms
`6764e1c`	1274.26 ms	1272.31 ms	-1.95 ms
`244c51c`	1254.56 ms	1257.16 ms	2.59 ms
`74346c0`	1266.35 ms	1263.75 ms	-2.60 ms
`84910f6`	1257.84 ms	1264.20 ms	6.37 ms
`d1b64ef`	1255.47 ms	1255.47 ms	0.00 ms
`55603c8`	1267.49 ms	1269.22 ms	1.74 ms
`b18a997`	1259.46 ms	1264.54 ms	5.08 ms
`c41e9d1`	1237.85 ms	1238.76 ms	0.90 ms
`0248c07`	1243.16 ms	1241.31 ms	-1.86 ms

App size

Revision	Plain	With Sentry	Diff
`9da5e55`	5.53 MiB	6.01 MiB	488.14 KiB
`6764e1c`	5.53 MiB	6.01 MiB	489.26 KiB
`244c51c`	5.53 MiB	6.01 MiB	488.13 KiB
`74346c0`	5.53 MiB	6.01 MiB	489.25 KiB
`84910f6`	5.53 MiB	6.01 MiB	488.13 KiB
`d1b64ef`	5.53 MiB	6.01 MiB	489.26 KiB
`55603c8`	5.53 MiB	6.01 MiB	489.25 KiB
`b18a997`	5.53 MiB	6.01 MiB	488.13 KiB
`c41e9d1`	5.53 MiB	6.01 MiB	488.13 KiB
`0248c07`	5.53 MiB	6.01 MiB	488.14 KiB

github-actions · 2025-10-31T10:28:36Z

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	442.94 ms	443.44 ms	0.50 ms
Size	13.93 MiB	15.06 MiB	1.13 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`1f639ee`	429.98 ms	476.60 ms	46.62 ms
`aeb02f2`	373.84 ms	437.00 ms	63.16 ms
`e04b24b`	504.72 ms	516.43 ms	11.71 ms
`c26ed0a`	465.52 ms	476.38 ms	10.86 ms
`9b99523`	456.91 ms	490.55 ms	33.64 ms
`827bf09`	475.40 ms	547.14 ms	71.74 ms
`d3fb366`	391.49 ms	385.85 ms	-5.64 ms
`29e8ebe`	389.91 ms	395.76 ms	5.84 ms
`0929dbf`	462.82 ms	492.76 ms	29.94 ms
`cf443d2`	464.64 ms	479.04 ms	14.40 ms

App size

Revision	Plain	With Sentry	Diff
`1f639ee`	13.93 MiB	15.00 MiB	1.06 MiB
`aeb02f2`	6.54 MiB	7.69 MiB	1.15 MiB
`e04b24b`	13.93 MiB	15.00 MiB	1.06 MiB
`c26ed0a`	13.93 MiB	14.93 MiB	1.00 MiB
`9b99523`	6.54 MiB	7.69 MiB	1.15 MiB
`827bf09`	6.54 MiB	7.53 MiB	1015.27 KiB
`d3fb366`	13.93 MiB	15.06 MiB	1.13 MiB
`29e8ebe`	13.93 MiB	15.06 MiB	1.13 MiB
`0929dbf`	6.54 MiB	7.70 MiB	1.17 MiB
`cf443d2`	13.93 MiB	15.00 MiB	1.06 MiB

Previous results on branch: enh/ffi-jni-replay-config

Startup times

Revision	Plain	With Sentry	Diff
`6764e1c`	376.88 ms	367.78 ms	-9.09 ms
`d1b64ef`	394.17 ms	417.64 ms	23.46 ms
`daacf58`	375.35 ms	381.94 ms	6.58 ms
`55603c8`	374.20 ms	355.75 ms	-18.45 ms
`c41e9d1`	360.29 ms	359.38 ms	-0.91 ms
`9da5e55`	428.88 ms	427.43 ms	-1.45 ms
`0d578c9`	449.69 ms	430.15 ms	-19.55 ms
`20b100b`	405.48 ms	407.50 ms	2.02 ms
`b18a997`	364.79 ms	362.28 ms	-2.52 ms
`74346c0`	389.92 ms	414.58 ms	24.66 ms

App size

Revision	Plain	With Sentry	Diff
`6764e1c`	13.93 MiB	15.06 MiB	1.13 MiB
`d1b64ef`	13.93 MiB	15.06 MiB	1.13 MiB
`daacf58`	13.93 MiB	15.06 MiB	1.13 MiB
`55603c8`	13.93 MiB	15.06 MiB	1.13 MiB
`c41e9d1`	13.93 MiB	15.06 MiB	1.13 MiB
`9da5e55`	13.93 MiB	15.06 MiB	1.13 MiB
`0d578c9`	13.93 MiB	15.06 MiB	1.13 MiB
`20b100b`	13.93 MiB	15.06 MiB	1.13 MiB
`b18a997`	13.93 MiB	15.06 MiB	1.13 MiB
`74346c0`	13.93 MiB	15.06 MiB	1.13 MiB

codecov · 2025-11-04T11:03:36Z

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.20%. Comparing base (e45380d) to head (5891010).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...r/lib/src/native/java/android_replay_recorder.dart	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3318      +/-   ##
==========================================
+ Coverage   88.25%   89.20%   +0.95%     
==========================================
  Files         295       99     -196     
  Lines       10120     3408    -6712     
==========================================
- Hits         8931     3040    -5891     
+ Misses       1189      368     -821

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.263.0 to 1.267.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@0481980...d5126b9) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-version: 1.267.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

buenaflor · 2025-11-04T13:40:34Z

Additionally manually checked the replays with orientation changes and looks good

EDIT: the detekt failure is because of the docker image used in the action: natiginfo/action-detekt-all#73

buenaflor added 3 commits October 31, 2025 08:54

Add support for captureReplay

d79f8f9

Remove method channel methods

aadb6b9

Update

74346c0

buenaflor added 3 commits October 31, 2025 10:29

Update

6764e1c

Update

d1b64ef

Add test for adjustReplaySizeToBlockSize

55603c8

denrase approved these changes Nov 3, 2025

View reviewed changes

buenaflor added 4 commits November 3, 2025 15:39

Update

8f1b69e

Add comment

b27d058

Update tests

7137617

Clean up

9da5e55

buenaflor and others added 14 commits November 4, 2025 13:17

Update tests

f572597

Update tests

c41e9d1

Update tests

0d578c9

Update tests

244c51c

Update tests

247313b

Update tests

20b100b

release: 9.8.0

336e06c

Replace Android emulator test step with unit test (#3319)

f196368

Update CHANGELOG

e5f85f1

Merge branch 'main' into enh/ffi-jni-replay-config

34c3af6

Use round() instead of toInt()

daacf58

Fix CHANGELOG

54a4ef1

buenaflor marked this pull request as ready for review November 4, 2025 13:45

buenaflor requested a review from stefanosiano as a code owner November 4, 2025 13:45

sentry Bot reviewed Nov 4, 2025

View reviewed changes

Comment thread packages/flutter/lib/src/native/java/sentry_native_java.dart

This comment was marked as outdated.

Sign in to view

buenaflor added 2 commits November 4, 2025 14:53

Update

e8ce749

Bug bot reviews

b18a997

This comment was marked as outdated.

Sign in to view

buenaflor added 2 commits November 4, 2025 15:06

Add test

84910f6

Fix test

5891010

buenaflor merged commit 6e7d494 into main Nov 4, 2025
51 of 52 checks passed

buenaflor deleted the enh/ffi-jni-replay-config branch November 4, 2025 15:24

Uh oh!

Uh oh!

Conversation

buenaflor commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions Bot commented Oct 31, 2025 • edited by buenaflor Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚨 Detected changes in high risk code 🚨

Uh oh!

github-actions Bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: enh/ffi-jni-replay-config

Startup times

App size

Uh oh!

github-actions Bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: enh/ffi-jni-replay-config

Startup times

App size

Uh oh!

codecov Bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

buenaflor commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

buenaflor commented Oct 31, 2025 •

edited

Loading

github-actions Bot commented Oct 31, 2025 •

edited by buenaflor

Loading

github-actions Bot commented Oct 31, 2025 •

edited

Loading

github-actions Bot commented Oct 31, 2025 •

edited

Loading

codecov Bot commented Nov 4, 2025 •

edited

Loading

buenaflor commented Nov 4, 2025 •

edited

Loading