enh: refactor setTag and removeTag to FFI/JNI#3313
Merged
Conversation
Contributor
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3313 +/- ##
==========================================
+ Coverage 88.13% 89.57% +1.44%
==========================================
Files 295 99 -196
Lines 10120 3406 -6714
==========================================
- Hits 8919 3051 -5868
+ Misses 1201 355 -846 ☔ View full report in Codecov by Sentry. |
buenaflor
marked this pull request as ready for review
October 30, 2025 09:04
denrase
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Part of moving away from method channels
💡 Motivation and Context
Partly completes #3204
💚 How did you test it?
Manual, integration tests
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps