Refactor: move native breadcrumbs sync to FFI/JNI by buenaflor · Pull Request #3293 · getsentry/sentry-dart

buenaflor · 2025-10-13T08:36:23Z

📜 Description

Part of FFI/JNI refactorings

💡 Motivation and Context

Partly completes #3204

💚 How did you test it?

Manual tests, integration test

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

…umbs-sync

denrase

Just a small comment regarding internal obj conversion. If we'll use this elsewhere, it would make sense to move to a util and add tests.

…umbs-sync

cursor · 2025-10-23T12:13:41Z

Bug: JNI Object Leaks in Dart-to-Java Conversion

JNI objects created during Dart-to-Java conversion in _dartToJList and _dartToJMap are not consistently released. This includes JString keys from entry.key.toJString() in _dartToJMap and JObject results from _dartToJObject(), leading to native memory leaks.

cursor · 2025-10-23T12:17:21Z

Bug: Silent Failures in Breadcrumb Method

The addBreadcrumb method silently returns when nativeOptions or nativeBreadcrumb are null, bypassing error logging. This behavior is inconsistent with the intent to log failures rather than failing silently.

github-actions · 2025-10-23T12:26:28Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1240.08 ms	1250.15 ms	10.06 ms
Size	5.53 MiB	6.01 MiB	488.15 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`32914d8`	1275.47 ms	1285.20 ms	9.73 ms
`a10aff4`	1241.67 ms	1255.02 ms	13.35 ms
`e04b24b`	1230.22 ms	1233.90 ms	3.67 ms
`40c8f93`	1234.27 ms	1261.98 ms	27.71 ms
`cf443d2`	1255.79 ms	1248.38 ms	-7.40 ms
`aeb02f2`	1244.29 ms	1256.55 ms	12.26 ms
`0fb3800`	1256.60 ms	1266.28 ms	9.68 ms
`944b773`	1252.82 ms	1254.08 ms	1.27 ms
`827bf09`	1261.86 ms	1276.41 ms	14.55 ms
`8541716`	1270.18 ms	1271.80 ms	1.62 ms

App size

Revision	Plain	With Sentry	Diff
`32914d8`	7.86 MiB	9.44 MiB	1.58 MiB
`a10aff4`	5.53 MiB	6.00 MiB	486.71 KiB
`e04b24b`	5.53 MiB	6.00 MiB	480.00 KiB
`40c8f93`	5.53 MiB	6.00 MiB	479.94 KiB
`cf443d2`	5.53 MiB	6.00 MiB	479.99 KiB
`aeb02f2`	7.86 MiB	9.44 MiB	1.58 MiB
`0fb3800`	7.86 MiB	9.44 MiB	1.58 MiB
`944b773`	5.53 MiB	6.00 MiB	479.98 KiB
`827bf09`	7.86 MiB	9.44 MiB	1.58 MiB
`8541716`	5.53 MiB	6.00 MiB	479.96 KiB

Previous results on branch: enh/ffi-jni-breadcrumbs-sync

Startup times

Revision	Plain	With Sentry	Diff
`5ad708c`	1240.73 ms	1236.33 ms	-4.40 ms
`bfb5259`	1257.88 ms	1255.78 ms	-2.10 ms
`0cfd7ba`	1242.02 ms	1239.67 ms	-2.35 ms
`1e52e9f`	1238.96 ms	1251.20 ms	12.24 ms
`a95a359`	1270.80 ms	1266.96 ms	-3.84 ms
`a2fda2c`	1260.47 ms	1255.32 ms	-5.15 ms
`d5857e8`	1255.33 ms	1256.29 ms	0.96 ms
`3a25e45`	1255.56 ms	1253.44 ms	-2.12 ms
`d4641f9`	1248.19 ms	1257.45 ms	9.26 ms
`5cc9c78`	1240.42 ms	1241.86 ms	1.44 ms

App size

Revision	Plain	With Sentry	Diff
`5ad708c`	5.53 MiB	6.00 MiB	485.58 KiB
`bfb5259`	5.53 MiB	6.01 MiB	487.41 KiB
`0cfd7ba`	5.53 MiB	6.00 MiB	485.59 KiB
`1e52e9f`	5.53 MiB	6.01 MiB	488.22 KiB
`a95a359`	5.53 MiB	6.01 MiB	488.13 KiB
`a2fda2c`	5.53 MiB	6.00 MiB	485.62 KiB
`d5857e8`	5.53 MiB	6.01 MiB	487.41 KiB
`3a25e45`	5.53 MiB	6.00 MiB	486.54 KiB
`d4641f9`	5.53 MiB	6.00 MiB	485.59 KiB
`5cc9c78`	5.53 MiB	6.00 MiB	486.52 KiB

github-actions · 2025-10-23T12:36:28Z

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	412.16 ms	401.08 ms	-11.08 ms
Size	13.93 MiB	15.06 MiB	1.13 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`5b9a0da`	446.94 ms	449.22 ms	2.28 ms
`0929dbf`	462.82 ms	492.76 ms	29.94 ms
`7b21e8b`	467.74 ms	466.24 ms	-1.50 ms
`4298701`	524.40 ms	633.30 ms	108.90 ms
`73dca78`	476.53 ms	522.21 ms	45.68 ms
`29e8ebe`	389.91 ms	395.76 ms	5.84 ms
`6b69699`	456.06 ms	557.44 ms	101.38 ms
`6ba4675`	499.80 ms	632.43 ms	132.63 ms
`8825ed8`	447.65 ms	456.90 ms	9.25 ms
`e45c0e1`	447.29 ms	558.33 ms	111.04 ms

App size

Revision	Plain	With Sentry	Diff
`5b9a0da`	13.93 MiB	14.93 MiB	1.00 MiB
`0929dbf`	6.54 MiB	7.70 MiB	1.17 MiB
`7b21e8b`	13.93 MiB	15.00 MiB	1.06 MiB
`4298701`	6.54 MiB	7.71 MiB	1.17 MiB
`73dca78`	6.54 MiB	7.69 MiB	1.15 MiB
`29e8ebe`	13.93 MiB	15.06 MiB	1.13 MiB
`6b69699`	6.54 MiB	7.70 MiB	1.17 MiB
`6ba4675`	6.54 MiB	7.53 MiB	1015.26 KiB
`8825ed8`	13.93 MiB	14.93 MiB	1.00 MiB
`e45c0e1`	6.54 MiB	7.70 MiB	1.16 MiB

Previous results on branch: enh/ffi-jni-breadcrumbs-sync

Startup times

Revision	Plain	With Sentry	Diff
`1e52e9f`	376.80 ms	364.85 ms	-11.95 ms
`bfb5259`	436.33 ms	426.84 ms	-9.49 ms
`a2fda2c`	488.88 ms	482.12 ms	-6.75 ms
`d5857e8`	453.85 ms	473.59 ms	19.74 ms
`5ad708c`	414.58 ms	446.49 ms	31.91 ms
`054c6ff`	416.62 ms	421.02 ms	4.41 ms
`5cc9c78`	415.94 ms	423.55 ms	7.61 ms
`a95a359`	418.08 ms	418.00 ms	-0.08 ms
`6bcf81b`	487.10 ms	490.40 ms	3.30 ms
`0cfd7ba`	420.21 ms	445.85 ms	25.65 ms

App size

Revision	Plain	With Sentry	Diff
`1e52e9f`	13.93 MiB	15.06 MiB	1.13 MiB
`bfb5259`	13.93 MiB	15.06 MiB	1.13 MiB
`a2fda2c`	13.93 MiB	15.06 MiB	1.13 MiB
`d5857e8`	13.93 MiB	15.06 MiB	1.13 MiB
`5ad708c`	13.93 MiB	15.06 MiB	1.13 MiB
`054c6ff`	13.93 MiB	15.06 MiB	1.13 MiB
`5cc9c78`	13.93 MiB	15.06 MiB	1.13 MiB
`a95a359`	13.93 MiB	15.06 MiB	1.13 MiB
`6bcf81b`	13.93 MiB	15.06 MiB	1.13 MiB
`0cfd7ba`	13.93 MiB	15.06 MiB	1.13 MiB

cursor · 2025-10-23T13:00:56Z

Bug: Async Methods Violate FutureOr Declaration

The addBreadcrumb and clearBreadcrumbs methods are declared as FutureOr<void> in ScopeObserver, but their NativeScopeObserver implementations use async. This forces them to always return Future<void>, contradicting the FutureOr declaration. Callers expecting a synchronous result might not await, potentially causing race conditions or unexecuted code.

Additional Locations (2)

buenaflor and others added 30 commits September 3, 2025 01:25

Update

03f8118

Update

6928f3a

Update

a91cbae

Update

a6bd3cc

Update

b9269c7

Update

6ef9960

Configure diagnostic log

a43f2e1

Update log messages

e334269

Update

aa728e7

Update

45cc8c3

Update

a603960

Update

147da01

Update

2b11149

Update

8325952

Update

3dbe751

Update

71ba593

Update

fe7f6df

Update

39a951e

Fix test

884642f

Update

f5f5401

Update

de232c6

Update

69d5111

Merge branch 'main' into enh/long-lived-envelope-worker

79d9ff9

Add automatedTestMode option

62bb12b

Merge branch 'main' into enh/long-lived-envelope-worker

532d2b3

Update

53c6036

Fix web tests

06ee227

Update

10d9419

Update

e6771bb

Add close

e2ae6a3

buenaflor and others added 4 commits October 17, 2025 08:36

Merge branch 'enh/app-hang-ffi-jni-refactor' into enh/ffi-jni-breadcr…

d4a7e17

…umbs-sync

Update

d5641dc

Update

8eb5153

Update

6bcf81b

This comment was marked as outdated.

Sign in to view

Update

5cc9c78

denrase approved these changes Oct 18, 2025

View reviewed changes

Comment thread packages/flutter/lib/src/native/java/sentry_native_java.dart Outdated

denrase mentioned this pull request Oct 18, 2025

Refactor app hang and native crash apis to FFI/JNI #3289

Merged

6 tasks

buenaflor and others added 5 commits October 20, 2025 09:30

Update

aacf1ff

Merge branch 'enh/app-hang-ffi-jni-refactor' into enh/ffi-jni-breadcr…

3a25e45

…umbs-sync

Update

714279e

Merge branch 'enh/app-hang-ffi-jni-refactor' into enh/ffi-jni-breadcr…

0ed0935

…umbs-sync

Update

b82a031

This comment was marked as outdated.

Sign in to view

Base automatically changed from enh/app-hang-ffi-jni-refactor to main October 23, 2025 12:03

buenaflor and others added 2 commits October 23, 2025 14:10

Merge branch 'main' into enh/ffi-jni-breadcrumbs-sync

f8616ed

Update

1e52e9f

buenaflor added 3 commits October 23, 2025 14:52

Update

a95a359

Fix analyze

0a10098

Remove comment

ca1fed5

getsentry deleted a comment from cursor Bot Oct 23, 2025

Update formatting

3729c2b

buenaflor merged commit c0dde50 into main Oct 23, 2025
120 of 121 checks passed

buenaflor deleted the enh/ffi-jni-breadcrumbs-sync branch October 23, 2025 13:29

Uh oh!

Uh oh!

Conversation

buenaflor commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

This comment was marked as outdated.

Uh oh!

denrase left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor Bot commented Oct 23, 2025

Bug: JNI Object Leaks in Dart-to-Java Conversion

Uh oh!

cursor Bot commented Oct 23, 2025

Bug: Silent Failures in Breadcrumb Method

Uh oh!

github-actions Bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: enh/ffi-jni-breadcrumbs-sync

Startup times

App size

Uh oh!

github-actions Bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: enh/ffi-jni-breadcrumbs-sync

Startup times

App size

Uh oh!

cursor Bot commented Oct 23, 2025

Bug: Async Methods Violate FutureOr Declaration

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

buenaflor commented Oct 13, 2025 •

edited

Loading

github-actions Bot commented Oct 23, 2025 •

edited

Loading

github-actions Bot commented Oct 23, 2025 •

edited

Loading