fix(sqflite): recursion in openDatabase when using SentrySqfliteDatabaseFactory#3231
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3231 +/- ##
==========================================
+ Coverage 87.93% 87.95% +0.01%
==========================================
Files 290 7 -283
Lines 9982 465 -9517
==========================================
- Hits 8778 409 -8369
+ Misses 1204 56 -1148 ☔ View full report in Codecov by Sentry. |
buenaflor
marked this pull request as ready for review
September 4, 2025 10:21
denrase
approved these changes
Sep 4, 2025
denrase
left a comment
denrase
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with one suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes a recursion happening when calling
openDatabaseon aSentrySqfliteDatabaseFactoryinstance where no database factory has been passed💡 Motivation and Context
Fixes #3229
💚 How did you test it?
Unit tests
Also ran the test without the fix which fails as expected
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps