Structured Logs: Don’t add template when there are no 'sentry.message.parameter.x’ attributes#3219
Merged
denrase merged 2 commits intoAug 29, 2025
Conversation
…o `'sentry.message.parameter.x’` attributes
denrase
marked this pull request as ready for review
August 29, 2025 09:16
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3219 +/- ##
=======================================
Coverage 87.86% 87.86%
=======================================
Files 289 289
Lines 9899 9901 +2
=======================================
+ Hits 8698 8700 +2
Misses 1201 1201 ☔ View full report in Codecov by Sentry. |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 81f83eb | 1259.53 ms | 1273.39 ms | 13.86 ms |
| 93b7728 | 1247.23 ms | 1264.87 ms | 17.64 ms |
| 827bf09 | 1261.86 ms | 1276.41 ms | 14.55 ms |
| eca355d | 1238.39 ms | 1266.98 ms | 28.59 ms |
| 79f6b41 | 1269.33 ms | 1279.71 ms | 10.38 ms |
| dbd526b | 1244.78 ms | 1259.02 ms | 14.24 ms |
| 73dca78 | 1246.65 ms | 1265.42 ms | 18.76 ms |
| c26ed0a | 1244.11 ms | 1263.85 ms | 19.75 ms |
| cc4e375 | 1253.06 ms | 1263.81 ms | 10.75 ms |
| b6c8720 | 1252.65 ms | 1266.61 ms | 13.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 81f83eb | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 93b7728 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 827bf09 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| eca355d | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 79f6b41 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| dbd526b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 73dca78 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| c26ed0a | 5.53 MiB | 5.97 MiB | 453.76 KiB |
| cc4e375 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| b6c8720 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
buenaflor
approved these changes
Aug 29, 2025
denrase
deleted the
fix/dont-add-template-atttribute-on-empty-arguments
branch
August 29, 2025 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Structured Logs: Don’t add template when there are no
'sentry.message.parameter.x’attributes💡 Motivation and Context
Relates to getsentry/sentry-docs#14759
Fixes #3217
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPiiis enabled