Skip to content

Add DioException response data to error breadcrumb#3164

Merged
denrase merged 4 commits into
mainfrom
enha/dio-exception-data
Aug 13, 2025
Merged

Add DioException response data to error breadcrumb#3164
denrase merged 4 commits into
mainfrom
enha/dio-exception-data

Conversation

@denrase

@denrase denrase commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

📜 Description

Add DioException response data to error breadcrumb

💡 Motivation and Context

Closes #3023

💚 How did you test it?

Tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@denrase
denrase marked this pull request as ready for review August 12, 2025 11:47
@codecov

codecov Bot commented Aug 12, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.04%. Comparing base (e10be73) to head (4afb647).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
+ Coverage   87.79%   97.04%   +9.24%     
==========================================
  Files         291        9     -282     
  Lines        9888      169    -9719     
==========================================
- Hits         8681      164    -8517     
+ Misses       1207        5    -1202     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread packages/dio/lib/src/breadcrumb_client_adapter.dart
@denrase
denrase requested a review from buenaflor August 12, 2025 11:55
@denrase

denrase commented Aug 13, 2025

Copy link
Copy Markdown
Collaborator Author

@buenaflor Needed to bump dio to ^5.2.0, as the DioException is not available in prior versions. It was released in June 23.

https://github.com/cfug/dio/releases/tag/dio_v5.2.0

@denrase
denrase merged commit dad9228 into main Aug 13, 2025
21 checks passed
@denrase
denrase deleted the enha/dio-exception-data branch August 13, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable detailed breadcrumbs for HTTP error responses in Dio’s Sentry Interceptor

2 participants