feat(feedback): Add option to disable keyboard resize#3154
Merged
denrase merged 4 commits intoAug 12, 2025
Conversation
daniel-chou-rainho
requested review from
buenaflor,
denrase and
stefanosiano
as code owners
August 8, 2025 12:09
denrase
approved these changes
Aug 11, 2025
denrase
left a comment
denrase
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Thanks for the detailed description. I merged in main and think we can merge once CI is happy.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3154 +/- ##
==========================================
+ Coverage 87.79% 89.90% +2.11%
==========================================
Files 291 96 -195
Lines 9887 3429 -6458
==========================================
- Hits 8680 3083 -5597
+ Misses 1207 346 -861 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Tests are only failing due to e2e token. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR adds a
resizeToAvoidBottomInsetoption toSentryFeedbackOptionsto allow developers to control whether the view resizes when the on-screen keyboard appears.This change is non-breaking as the option defaults to true (the current behavior).
💡 Motivation and Context
The current default behavior for the feedback widget is to resize the view when a text field is focused. This pushes the bottom action buttons ("Send" and "Cancel") up above the keyboard, which can be visually disruptive.
This change introduces an option to disable this resizing, allowing the keyboard to overlay the UI instead.
Click to see UI comparison
💚 How did you test it?
resizeToAvoidBottomInsetto false in the Sentry options resulted in the keyboard overlaying the UI.true) remained unchanged.flutter testto check for any regressions.📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
Ready for review.