feat(logs): add origin to logs created by LoggingIntegration#3153
Merged
Conversation
Contributor
|
buenaflor
commented
Aug 7, 2025
| late SentryOptions _options; | ||
|
|
||
| @internal | ||
| static const origin = 'auto.log.logging'; |
Contributor
Author
There was a problem hiding this comment.
e.g Java will add auto.log.logback for their logback integration with logs
also open to replacing logging with something else but since it's the name of the package it's fine I think
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3153 +/- ##
==========================================
+ Coverage 88.63% 97.01% +8.38%
==========================================
Files 278 2 -276
Lines 9492 67 -9425
==========================================
- Hits 8413 65 -8348
+ Misses 1079 2 -1077 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added needed origin: https://develop.sentry.dev/sdk/telemetry/logs/#sdk-integration-attributes
💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps