ThreadInfo integration should only be added for non-web platforms #3144
Merged
Conversation
denrase
changed the title
ThreadInfo integration should only be added for non-web platforms
denrase
marked this pull request as ready for review
August 6, 2025 09:34
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3144 +/- ##
==========================================
+ Coverage 87.78% 89.90% +2.11%
==========================================
Files 291 96 -195
Lines 9885 3428 -6457
==========================================
- Hits 8678 3082 -5596
+ Misses 1207 346 -861 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2cb90b9 | 1272.90 ms | 1285.55 ms | 12.66 ms |
| dbd526b | 1244.78 ms | 1259.02 ms | 14.24 ms |
| 81f83eb | 1259.53 ms | 1273.39 ms | 13.86 ms |
| 73dca78 | 1246.65 ms | 1265.42 ms | 18.76 ms |
| 6b69699 | 1254.80 ms | 1273.31 ms | 18.52 ms |
| f761369 | 1261.69 ms | 1277.82 ms | 16.12 ms |
| 640ad0c | 1241.04 ms | 1253.96 ms | 12.92 ms |
| 7cfbbd6 | 1270.63 ms | 1285.36 ms | 14.72 ms |
| e45c0e1 | 1269.08 ms | 1278.83 ms | 9.75 ms |
| cc4e375 | 1253.06 ms | 1263.81 ms | 10.75 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2cb90b9 | 7.86 MiB | 9.54 MiB | 1.69 MiB |
| dbd526b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 81f83eb | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 73dca78 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 6b69699 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| f761369 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 640ad0c | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 7cfbbd6 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| e45c0e1 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| cc4e375 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9b99523 | 456.91 ms | 490.55 ms | 33.64 ms |
| ec78888 | 457.94 ms | 519.96 ms | 62.02 ms |
| 32914d8 | 461.96 ms | 495.47 ms | 33.51 ms |
| 793f4dc | 462.68 ms | 544.21 ms | 81.53 ms |
| e2d675d | 457.92 ms | 529.17 ms | 71.25 ms |
| f761369 | 462.73 ms | 563.80 ms | 101.06 ms |
| 2cf9161 | 454.12 ms | 512.67 ms | 58.55 ms |
| aeb02f2 | 373.84 ms | 437.00 ms | 63.16 ms |
| 4481076 | 484.08 ms | 505.70 ms | 21.61 ms |
| 6ba4675 | 499.80 ms | 632.43 ms | 132.63 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9b99523 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| ec78888 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 32914d8 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 793f4dc | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| e2d675d | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| f761369 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 2cf9161 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| aeb02f2 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 4481076 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 6ba4675 | 6.54 MiB | 7.53 MiB | 1015.26 KiB |
buenaflor
reviewed
Aug 6, 2025
Co-authored-by: Giancarlo Buenaflor <[email protected]>
buenaflor
approved these changes
Aug 6, 2025
Contributor
|
@denrase before you merge this pls wait for the melos PR to be merged so we can avoid some conflicts |
Contributor
|
this PR can be rebased and merged now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
ThreadInfo integration should only be added for non-web platforms
💡 Motivation and Context
Closes #3143
💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps