Add LoggingIntegration support for SentryLog#3050
Merged
Merged
Conversation
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3050 +/- ##
==========================================
+ Coverage 87.85% 96.96% +9.11%
==========================================
Files 287 2 -285
Lines 9733 66 -9667
==========================================
- Hits 8551 64 -8487
+ Misses 1182 2 -1180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
denrase
marked this pull request as ready for review
July 8, 2025 09:49
buenaflor
changed the title
LoggingIntegration support for SenryLogLoggingIntegration support for SentryLog
buenaflor
reviewed
Jul 8, 2025
Collaborator
Author
|
@buenaflor Also not sure if there is some case where we want to map to the |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 640ad0c | 1241.04 ms | 1253.96 ms | 12.92 ms |
| ec78888 | 1251.37 ms | 1269.40 ms | 18.04 ms |
| 2d34233 | 1258.19 ms | 1268.92 ms | 10.73 ms |
| e2d675d | 1238.48 ms | 1242.76 ms | 4.28 ms |
| b6c8720 | 1252.65 ms | 1266.61 ms | 13.96 ms |
| 73dca78 | 1246.65 ms | 1265.42 ms | 18.76 ms |
| 0fb3800 | 1256.60 ms | 1266.28 ms | 9.68 ms |
| aeb02f2 | 1244.29 ms | 1256.55 ms | 12.26 ms |
| 6ba4675 | 1223.12 ms | 1238.17 ms | 15.04 ms |
| 73a3c38 | 1263.37 ms | 1277.90 ms | 14.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 640ad0c | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| ec78888 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 2d34233 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| e2d675d | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| b6c8720 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 73dca78 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 0fb3800 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| aeb02f2 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 6ba4675 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 73a3c38 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
buenaflor
reviewed
Jul 8, 2025
buenaflor
reviewed
Jul 9, 2025
buenaflor
reviewed
Jul 9, 2025
buenaflor
reviewed
Jul 10, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 575ebaa | 478.00 ms | 585.76 ms | 107.76 ms |
| ec78888 | 457.94 ms | 519.96 ms | 62.02 ms |
| 81f83eb | 471.40 ms | 522.14 ms | 50.74 ms |
| 0fb3800 | 465.64 ms | 536.77 ms | 71.13 ms |
| e2d675d | 457.92 ms | 529.17 ms | 71.25 ms |
| 9b99523 | 456.91 ms | 490.55 ms | 33.64 ms |
| c8596a6 | 474.00 ms | 492.96 ms | 18.96 ms |
| 73dca78 | 476.53 ms | 522.21 ms | 45.68 ms |
| 793f4dc | 462.68 ms | 544.21 ms | 81.53 ms |
| 93b7728 | 475.28 ms | 489.13 ms | 13.86 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 575ebaa | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| ec78888 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 81f83eb | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 0fb3800 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| e2d675d | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 9b99523 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| c8596a6 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
| 73dca78 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 793f4dc | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 93b7728 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
Contributor
|
@denrase pls check the cursor comment above |
…m:getsentry/sentry-dart into feat/logging-integration-support-for-logs # Conflicts: # logging/lib/src/logging_integration.dart
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Author
|
@buenaflor Handled the cases according to their numeric values. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
buenaflor
reviewed
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add
LoggingIntegrationsupport forSentryLog💡 Motivation and Context
Closes #2973
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPiiis enabled