Skip to content

deps upgrade Kotlin languageVersion to 1.8#3032

Merged
buenaflor merged 5 commits into
mainfrom
fix/kotlin-language-version
Jul 3, 2025
Merged

deps upgrade Kotlin languageVersion to 1.8#3032
buenaflor merged 5 commits into
mainfrom
fix/kotlin-language-version

Conversation

@buenaflor

@buenaflor buenaflor commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

📜 Description

Fixes error

Task :sentry_flutter:compileDebugKotlin FAILED
e: Language version 1.6 is no longer supported; please, use version 1.8 or greater.

which happens when bumping the kotlin-android plugin to 2.2.0

💡 Motivation and Context

Closes #3028

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov

codecov Bot commented Jul 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.09%. Comparing base (8c8e541) to head (ad3ab4f).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (8c8e541) and HEAD (ad3ab4f). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (8c8e541) HEAD (ad3ab4f)
9 1
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #3032       +/-   ##
===========================================
- Coverage   87.97%   63.09%   -24.89%     
===========================================
  Files         287        4      -283     
  Lines        9533      168     -9365     
===========================================
- Hits         8387      106     -8281     
+ Misses       1146       62     -1084

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

denrase
denrase approved these changes Jul 2, 2025
View reviewed changes
Comment thread CHANGELOG.md Outdated

### Dependencies

- Upgrade Kotlin languageVersion to `1.8` ([#3032](https://github.com/getsentry/sentry-dart/pull/3032))

@denrase denrase Jul 2, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mark this a s a breaking change?

@buenaflor buenaflor Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll mark it as potentially breaking. the number of people potentially affected should be really low

@buenaflor buenaflor Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'll try it out first myself in a sample app

@buenaflor buenaflor Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out, still compiles even with older plugin versions fine

@buenaflor
buenaflor requested a review from kahest July 2, 2025 14:15
@buenaflor

buenaflor commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

changelog sanity check. since @stefanosiano clarified it's fine to update it and won't affect users, I guess it shouldn't hurt to still call out to update the toolchain if its outdated?

@kahest

kahest commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

changelog sanity check. since @stefanosiano clarified it's fine to update it and won't affect users, I guess it shouldn't hurt to still call out to update the toolchain if its outdated?

yep we should call it out clearly, it's still a breaking change in the sense that people might need to update toolchains not just locally, but also on CI etc.

@buenaflor

buenaflor commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

Updated the changelog

@buenaflor

buenaflor commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

@kahest wdyt of the changelog, updated it to be 'potentially breaking'

kahest
kahest approved these changes Jul 3, 2025
View reviewed changes
Comment thread CHANGELOG.md Outdated
@buenaflor @kahest
Update CHANGELOG.md
ad3ab4f 
Co-authored-by: Karl Heinz Struggl <[email protected]>
@buenaflor
buenaflor merged commit c8596a6 into main Jul 3, 2025
52 of 57 checks passed
@buenaflor
buenaflor deleted the fix/kotlin-language-version branch July 3, 2025 09:38
@github-actions

github-actions Bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor
Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- deps upgrade Kotlin languageVersion to `1.8` ([#3032](https://github.com/getsentry/sentry-dart/pull/3032))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against ad3ab4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denrase denrase denrase approved these changes
@stefanosiano stefanosiano Awaiting requested review from stefanosiano
+1 more reviewer
@kahest kahest kahest approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compilation errors in Sentry Flutter due to Kotlin API incompatibilities. (Language version 1.6 is no longer supported)

3 participants

@buenaflor @kahest @denrase