Dont execute app start integration if tracing is disabled#3026
Conversation
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3026 +/- ##
==========================================
+ Coverage 87.73% 89.10% +1.37%
==========================================
Files 286 95 -191
Lines 9340 3140 -6200
==========================================
- Hits 8194 2798 -5396
+ Misses 1146 342 -804 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
denrase
left a comment
denrase
left a comment
There was a problem hiding this comment.
Just a suggestions regarding naming.
| this._frameCallbackHandler, this._nativeAppStartHandler); | ||
|
|
||
| @internal | ||
| static const integrationName = 'nativeAppStartIntegration'; |
There was a problem hiding this comment.
Should we rename this to NativeAppStart to match the new format, or do we need this to be like before?
There was a problem hiding this comment.
I wanted to do it all in one shot in another PR but I guess since I'm on this one alreadty it makes sense to update it here
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e788bd4 | 1252.45 ms | 1264.48 ms | 12.03 ms |
| aba65ca | 1248.83 ms | 1268.30 ms | 19.46 ms |
| 4fecc12 | 1253.92 ms | 1281.13 ms | 27.21 ms |
| 3ad66e4 | 1230.44 ms | 1245.08 ms | 14.65 ms |
| d783424 | 1265.71 ms | 1277.00 ms | 11.29 ms |
| 299a3f6 | 1231.02 ms | 1249.00 ms | 17.98 ms |
| f79eecf | 1210.25 ms | 1221.65 ms | 11.40 ms |
| c5616a6 | 1237.94 ms | 1252.92 ms | 14.98 ms |
| db64b25 | 1258.20 ms | 1275.21 ms | 17.01 ms |
| be7a831 | 1262.78 ms | 1282.98 ms | 20.20 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e788bd4 | 7.85 MiB | 9.44 MiB | 1.59 MiB |
| aba65ca | 8.38 MiB | 9.73 MiB | 1.35 MiB |
| 4fecc12 | 8.43 MiB | 9.97 MiB | 1.54 MiB |
| 3ad66e4 | 8.32 MiB | 9.38 MiB | 1.05 MiB |
| d783424 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
| 299a3f6 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
| f79eecf | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| c5616a6 | 7.85 MiB | 9.42 MiB | 1.57 MiB |
| db64b25 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| be7a831 | 8.38 MiB | 9.77 MiB | 1.40 MiB |
2 participants
💡 Motivation and Context
Small enhancement
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps