fix: crashpad path not being found by buenaflor · Pull Request #3016 · getsentry/sentry-dart

buenaflor · 2025-06-25T16:19:41Z

📜 Description

Add additional candidate to search for the crashpad handler

💡 Motivation and Context

Partly fixes #3009

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

codecov · 2025-06-25T16:20:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.09%. Comparing base (2d34233) to head (0babfc0).

❗ There is a different number of reports uploaded between BASE (2d34233) and HEAD (0babfc0). Click for more details.

HEAD has 8 uploads less than BASE

Flag BASE (2d34233) HEAD (0babfc0)

9 1

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3016       +/-   ##
===========================================
- Coverage   87.97%   63.09%   -24.89%     
===========================================
  Files         287        4      -283     
  Lines        9533      168     -9365     
===========================================
- Hits         8387      106     -8281     
+ Misses       1146       62     -1084

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2025-06-25T16:34:33Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1244.98 ms	1263.91 ms	18.94 ms
Size	7.86 MiB	9.44 MiB	1.58 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`827bf09`	1261.86 ms	1276.41 ms	14.55 ms
`c8596a6`	1234.11 ms	1241.19 ms	7.08 ms
`2d34233`	1258.19 ms	1268.92 ms	10.73 ms
`6ba4675`	1223.12 ms	1238.17 ms	15.04 ms

App size

Revision	Plain	With Sentry	Diff
`827bf09`	7.86 MiB	9.44 MiB	1.58 MiB
`c8596a6`	7.86 MiB	9.44 MiB	1.58 MiB
`2d34233`	7.86 MiB	9.44 MiB	1.58 MiB
`6ba4675`	7.86 MiB	9.44 MiB	1.58 MiB

Previous results on branch: fix/native-crashpad-handler

Startup times

Revision	Plain	With Sentry	Diff
`4022001`	1260.67 ms	1271.04 ms	10.38 ms
`205e143`	1259.88 ms	1271.65 ms	11.78 ms
`f5ce835`	1260.10 ms	1277.53 ms	17.43 ms
`7884ddb`	1265.19 ms	1273.42 ms	8.23 ms
`1c000ef`	1257.43 ms	1272.60 ms	15.18 ms

App size

Revision	Plain	With Sentry	Diff
`4022001`	7.85 MiB	9.45 MiB	1.59 MiB
`205e143`	7.85 MiB	9.45 MiB	1.59 MiB
`f5ce835`	7.86 MiB	9.44 MiB	1.58 MiB
`7884ddb`	7.86 MiB	9.44 MiB	1.58 MiB
`1c000ef`	7.85 MiB	9.45 MiB	1.59 MiB

github-actions · 2025-06-25T16:37:30Z

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	478.62 ms	528.28 ms	49.66 ms
Size	6.54 MiB	7.55 MiB	1.01 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`c8596a6`	474.00 ms	492.96 ms	18.96 ms
`6ba4675`	499.80 ms	632.43 ms	132.63 ms
`827bf09`	475.40 ms	547.14 ms	71.74 ms
`2d34233`	470.54 ms	558.90 ms	88.36 ms

App size

Revision	Plain	With Sentry	Diff
`c8596a6`	6.54 MiB	7.53 MiB	1015.27 KiB
`6ba4675`	6.54 MiB	7.53 MiB	1015.26 KiB
`827bf09`	6.54 MiB	7.53 MiB	1015.27 KiB
`2d34233`	6.54 MiB	7.55 MiB	1.01 MiB

Previous results on branch: fix/native-crashpad-handler

Startup times

Revision	Plain	With Sentry	Diff
`4022001`	463.79 ms	523.67 ms	59.88 ms
`205e143`	452.96 ms	528.40 ms	75.44 ms
`7884ddb`	454.91 ms	526.73 ms	71.81 ms
`f5ce835`	454.59 ms	533.57 ms	78.98 ms
`1c000ef`	453.53 ms	526.22 ms	72.69 ms

App size

Revision	Plain	With Sentry	Diff
`4022001`	6.54 MiB	7.53 MiB	1017.81 KiB
`205e143`	6.54 MiB	7.53 MiB	1016.34 KiB
`7884ddb`	6.54 MiB	7.53 MiB	1015.26 KiB
`f5ce835`	6.54 MiB	7.53 MiB	1015.26 KiB
`1c000ef`	6.54 MiB	7.53 MiB	1016.34 KiB

buenaflor · 2025-06-27T08:50:29Z

this still won't fix the permission issue so might as well do it in one shot once we have a way to work around it

denrase

Just a question, rest looks ok to me. Any way we can verify this works when the handler is at the additional path we added?

buenaflor · 2025-07-03T15:59:41Z

We dont test this in CI (I guess we should) but the user confirmed in the issue it works

github-actions · 2025-07-04T09:01:15Z

	Fails
🚫	Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- crashpad path not being found ([#3016](https://github.com/getsentry/sentry-dart/pull/3016))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against f580643

buenaflor added 2 commits June 25, 2025 11:33

Add another candidate

1e70ba8

Add log

4022001

buenaflor requested review from denrase and stefanosiano as code owners June 25, 2025 16:19

buenaflor and others added 2 commits June 25, 2025 18:21

Update CHANGELOG{

06e5a46

Merge branch 'main' into fix/native-crashpad-handler

1c000ef

Update sentry_flutter.dart

205e143

buenaflor changed the title ~~fix: add crashpad path candidate~~ fix: crashpad path not being found Jun 25, 2025

jefflongo reviewed Jun 25, 2025

View reviewed changes

Comment thread flutter/lib/src/native/c/sentry_native.dart Outdated

buenaflor marked this pull request as draft June 27, 2025 08:50

Update

d619fcf

buenaflor marked this pull request as ready for review July 3, 2025 11:16

buenaflor and others added 4 commits July 3, 2025 13:16

Merge branch 'main' into fix/native-crashpad-handler

7857f7c

Update CHANGELOG

3ae9f5d

Merge branch 'main' into fix/native-crashpad-handler

7884ddb

Update sentry_native.dart

f5ce835

denrase reviewed Jul 3, 2025

View reviewed changes

Comment thread flutter/lib/src/native/c/sentry_native.dart

denrase approved these changes Jul 3, 2025

View reviewed changes

buenaflor and others added 4 commits July 3, 2025 19:57

Merge branch 'main' into fix/native-crashpad-handler

66f006a

Update CHANGELOG.md

ebadfeb

Update

0babfc0

Merge branch 'main' into fix/native-crashpad-handler

f580643

buenaflor merged commit b6c8720 into main Jul 4, 2025
3 of 4 checks passed

buenaflor deleted the fix/native-crashpad-handler branch July 4, 2025 08:59

Uh oh!

Uh oh!

Conversation

buenaflor commented Jun 25, 2025

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

codecov Bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: fix/native-crashpad-handler

Startup times

App size

Uh oh!

github-actions Bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: fix/native-crashpad-handler

Startup times

App size

Uh oh!

Uh oh!

buenaflor commented Jun 27, 2025

Uh oh!

Uh oh!

denrase left a comment

Choose a reason for hiding this comment

Uh oh!

buenaflor commented Jul 3, 2025

Uh oh!

Uh oh!

github-actions Bot commented Jul 4, 2025

Instructions and example for changelog

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Jun 25, 2025 •

edited

Loading

github-actions Bot commented Jun 25, 2025 •

edited

Loading

github-actions Bot commented Jun 25, 2025 •

edited

Loading