Set Firebase Remote Config flags on integration initialization#3008
Merged
buenaflor merged 7 commits intoJun 30, 2025
Merged
Conversation
kurtmarcink
requested review from
buenaflor,
denrase and
stefanosiano
as code owners
June 24, 2025 20:07
buenaflor
reviewed
Jun 24, 2025
Co-authored-by: Giancarlo Buenaflor <[email protected]>
6 tasks
Contributor
|
only missing piece is to add a changelog entry |
denrase
requested changes
Jun 25, 2025
denrase
left a comment
denrase
left a comment
Collaborator
There was a problem hiding this comment.
Just some smaller refactoring suggestions. Thank you for your contribution! 🙇
…-flag-initialization' into feat/firebase-remote-config-flag-initialization
denrase
approved these changes
Jun 30, 2025
denrase
left a comment
denrase
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! 🥳 We only need to sync with main and add the cahngelog entry, if not already there.
Contributor
Author
@denrase Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Calls
Sentry.addFeatureFlagon initialization ofSentryFirebaseRemoteConfigIntegration.💡 Motivation and Context
Fixes #3007
💚 How did you test it?
flutter test firebase_remote_config/test/src/sentry_firebase_remote_config_integration_test.dart📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
N/A