SentryFeedbackWidget Improvements #2964
Merged
Merged
Conversation
Contributor
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2964 +/- ##
==========================================
+ Coverage 87.71% 87.99% +0.28%
==========================================
Files 286 287 +1
Lines 9342 9533 +191
==========================================
+ Hits 8194 8389 +195
+ Misses 1148 1144 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 752e1cb | 472.85 ms | 511.60 ms | 38.76 ms |
| 0ceb89c | 304.57 ms | 357.18 ms | 52.61 ms |
| 3a69405 | 334.34 ms | 369.19 ms | 34.85 ms |
| 9f05645 | 349.43 ms | 437.24 ms | 87.81 ms |
| c689845 | 460.32 ms | 537.02 ms | 76.70 ms |
| bb57a41 | 408.30 ms | 430.86 ms | 22.56 ms |
| fbf42af | 323.04 ms | 365.09 ms | 42.04 ms |
| 1cc9547 | 444.14 ms | 513.58 ms | 69.44 ms |
| f9d18f3 | 430.94 ms | 497.59 ms | 66.65 ms |
| e8603bb | 377.51 ms | 444.77 ms | 67.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 752e1cb | 6.49 MiB | 7.57 MiB | 1.08 MiB |
| 0ceb89c | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 3a69405 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 9f05645 | 6.27 MiB | 7.20 MiB | 958.60 KiB |
| c689845 | 6.46 MiB | 7.48 MiB | 1.01 MiB |
| bb57a41 | 6.54 MiB | 7.53 MiB | 1016.34 KiB |
| fbf42af | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 1cc9547 | 6.46 MiB | 7.48 MiB | 1.01 MiB |
| f9d18f3 | 6.15 MiB | 7.13 MiB | 1000.49 KiB |
| e8603bb | 6.34 MiB | 7.28 MiB | 967.80 KiB |
Previous results on branch: feat/imporve-user-feedback-widget
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9f73d00 | 455.15 ms | 532.58 ms | 77.43 ms |
| d5bfab8 | 450.79 ms | 492.04 ms | 41.25 ms |
| a5ea1aa | 453.20 ms | 520.36 ms | 67.16 ms |
| 62f0687 | 457.10 ms | 518.62 ms | 61.52 ms |
| d99d55b | 458.37 ms | 524.06 ms | 65.69 ms |
| 680f402 | 548.33 ms | 625.57 ms | 77.24 ms |
| 5848af1 | 426.16 ms | 489.23 ms | 63.07 ms |
| 23ff8a6 | 493.56 ms | 556.38 ms | 62.82 ms |
| f84f616 | 470.73 ms | 503.86 ms | 33.13 ms |
| 9592079 | 474.51 ms | 530.07 ms | 55.55 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9f73d00 | 6.54 MiB | 7.53 MiB | 1018.15 KiB |
| d5bfab8 | 6.54 MiB | 7.53 MiB | 1016.51 KiB |
| a5ea1aa | 6.54 MiB | 7.53 MiB | 1016.51 KiB |
| 62f0687 | 6.44 MiB | 7.50 MiB | 1.05 MiB |
| d99d55b | 6.54 MiB | 7.53 MiB | 1017.81 KiB |
| 680f402 | 6.54 MiB | 7.53 MiB | 1016.51 KiB |
| 5848af1 | 6.54 MiB | 7.53 MiB | 1017.67 KiB |
| 23ff8a6 | 6.44 MiB | 7.50 MiB | 1.05 MiB |
| f84f616 | 6.54 MiB | 7.53 MiB | 1016.51 KiB |
| 9592079 | 6.44 MiB | 7.51 MiB | 1.06 MiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f3a18f2 | 1246.86 ms | 1268.00 ms | 21.14 ms |
| 3925712 | 1257.91 ms | 1276.37 ms | 18.45 ms |
| b2cbbc8 | 1240.00 ms | 1254.37 ms | 14.37 ms |
| dd5521e | 1254.28 ms | 1263.37 ms | 9.09 ms |
| 5e8d2b3 | 1255.71 ms | 1267.98 ms | 12.27 ms |
| 4d046e0 | 1243.08 ms | 1255.98 ms | 12.90 ms |
| 03e4c9b | 1241.96 ms | 1247.00 ms | 5.04 ms |
| ec50b21 | 1261.87 ms | 1274.43 ms | 12.55 ms |
| 05933ac | 1258.37 ms | 1285.57 ms | 27.21 ms |
| e893df5 | 1247.90 ms | 1262.31 ms | 14.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f3a18f2 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
| 3925712 | 7.85 MiB | 9.45 MiB | 1.59 MiB |
| b2cbbc8 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| dd5521e | 8.43 MiB | 9.97 MiB | 1.54 MiB |
| 5e8d2b3 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| 4d046e0 | 8.42 MiB | 9.83 MiB | 1.40 MiB |
| 03e4c9b | 8.34 MiB | 9.67 MiB | 1.33 MiB |
| ec50b21 | 8.42 MiB | 9.89 MiB | 1.46 MiB |
| 05933ac | 8.38 MiB | 9.78 MiB | 1.40 MiB |
| e893df5 | 8.09 MiB | 9.07 MiB | 1001.04 KiB |
Previous results on branch: feat/imporve-user-feedback-widget
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5848af1 | 1242.07 ms | 1258.90 ms | 16.83 ms |
| 680f402 | 1254.80 ms | 1269.76 ms | 14.95 ms |
| 23ff8a6 | 1241.63 ms | 1260.20 ms | 18.57 ms |
| 3687d4f | 1264.86 ms | 1281.39 ms | 16.53 ms |
| 62f0687 | 1244.63 ms | 1263.07 ms | 18.44 ms |
| 09c60a5 | 1247.39 ms | 1270.30 ms | 22.91 ms |
| 9f73d00 | 1260.82 ms | 1265.20 ms | 4.39 ms |
| a5ea1aa | 1234.21 ms | 1243.83 ms | 9.63 ms |
| d99d55b | 1266.29 ms | 1274.09 ms | 7.79 ms |
| 2a151e2 | 1243.96 ms | 1255.74 ms | 11.79 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5848af1 | 7.85 MiB | 9.42 MiB | 1.57 MiB |
| 680f402 | 7.85 MiB | 9.45 MiB | 1.59 MiB |
| 23ff8a6 | 8.43 MiB | 10.04 MiB | 1.61 MiB |
| 3687d4f | 7.85 MiB | 9.42 MiB | 1.57 MiB |
| 62f0687 | 8.43 MiB | 10.04 MiB | 1.61 MiB |
| 09c60a5 | 8.43 MiB | 10.05 MiB | 1.62 MiB |
| 9f73d00 | 7.86 MiB | 9.45 MiB | 1.59 MiB |
| a5ea1aa | 7.85 MiB | 9.45 MiB | 1.59 MiB |
| d99d55b | 7.85 MiB | 9.45 MiB | 1.59 MiB |
| 2a151e2 | 7.85 MiB | 9.45 MiB | 1.59 MiB |
ueman
reviewed
May 27, 2025
denrase
marked this pull request as ready for review
May 28, 2025 15:28
denrase
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
May 28, 2025 15:28
Collaborator
Author
|
@ueman Checked the docs for SR. It is described that unique ID on iOS on the project level has to be set in the |
Collaborator
|
I haven't used the API yet, but the docs indeed imply that the user needs to tke action which is very unfortunate |
buenaflor
reviewed
Jun 25, 2025
Contributor
There was a problem hiding this comment.
We want to track usage of the Widget (dev usage, not usage of the user who opens the widget) so we should add something like options.sdk.integrations('MobileFeedbackWidget');
Maybe we find a way to add it even if the user hasn't opened the widget yet - if at all possible? not sure
Collaborator
Author
|
@buenaflor Added the integration when the options are accessed. This is not 100% accurate if we want to track if developers are using the feature, but it's the closest we can get with the current structure. |
buenaflor
reviewed
Jun 27, 2025
buenaflor
reviewed
Jun 30, 2025
buenaflor
reviewed
Jun 30, 2025
buenaflor
approved these changes
Jul 1, 2025
buenaflor
left a comment
buenaflor
left a comment
Contributor
There was a problem hiding this comment.
looks good, lets merge it after 9.2.0 is released
also pls update the docs if needed
buenaflor
added a commit
that referenced
this pull request
Jul 2, 2025
* Read default values from options * Add screenshot from camera roll * Implmenet „Take Screenshot“ functionality * move things around * only read from feedback options * remove unused import * revert sentry widget changes * make final instead of late final * removeredundant comments * implement @ueman feedback * ui customization, logo, tests * update and fix tests * set screenshot, fix button shape * cleanup, changelog * revert * cleanup * move key to button * move key to button * replace spacing with sizedbox * fix logo * update cl * Remove iamge picking for now * remove generated files when running example * fix comment * remove feature from cl * remove addScreenshotButtonLabel * remove unneccessary call, which is also not available on lower sdk versions * update cl * Fix spelling error * Save and restore form data when taking a screenshot * fix cl * Capture replay when feedback widget is opened * Add integration name when feedback options are accessed * implement mock stub * update changelog * flush replay on manual feedback * format * add comment * introduce internal typecheckhint * format * format --------- Co-authored-by: Giancarlo Buenaflor <[email protected]> Co-authored-by: Giancarlo Buenaflor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
pick screenshot💡 Motivation and Context
Closes #2697
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
Document iOS/Android strings from camera roll accessnot needed with current setupDouble check Android issue with app being terminated while picking image.