Fix feature flag model keys#2943
Merged
Merged
Conversation
Collaborator
Author
|
@buenaflor I somehow mixed up the JSON keys. I remember seeing them in the event contexts in the old sentry.io UI, thinking that was enough/correct. Sorry about that. |
denrase
marked this pull request as ready for review
May 14, 2025 12:57
denrase
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
May 14, 2025 12:57
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5e8d2b3 | 1255.71 ms | 1267.98 ms | 12.27 ms |
| 051e97a | 1245.94 ms | 1249.51 ms | 3.57 ms |
| 07cd9e8 | 1237.04 ms | 1257.50 ms | 20.46 ms |
| 7fd33d3 | 1241.92 ms | 1265.47 ms | 23.55 ms |
| a24a1db | 1257.71 ms | 1271.57 ms | 13.87 ms |
| 5aa047a | 1236.57 ms | 1241.02 ms | 4.45 ms |
| abfcdb5 | 1230.87 ms | 1244.94 ms | 14.06 ms |
| 7659cbe | 1246.70 ms | 1265.88 ms | 19.17 ms |
| 4d046e0 | 1243.08 ms | 1255.98 ms | 12.90 ms |
| bd1b990 | 1209.43 ms | 1226.96 ms | 17.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5e8d2b3 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| 051e97a | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| 07cd9e8 | 8.38 MiB | 9.77 MiB | 1.40 MiB |
| 7fd33d3 | 8.38 MiB | 9.78 MiB | 1.40 MiB |
| a24a1db | 8.42 MiB | 9.91 MiB | 1.49 MiB |
| 5aa047a | 8.29 MiB | 9.39 MiB | 1.10 MiB |
| abfcdb5 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| 7659cbe | 8.42 MiB | 9.89 MiB | 1.47 MiB |
| 4d046e0 | 8.42 MiB | 9.83 MiB | 1.40 MiB |
| bd1b990 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
buenaflor
approved these changes
May 14, 2025
buenaflor
left a comment
buenaflor
left a comment
Contributor
There was a problem hiding this comment.
Thanks, good thing we caught this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2943 +/- ##
==========================================
+ Coverage 87.63% 88.66% +1.03%
==========================================
Files 272 100 -172
Lines 9047 3669 -5378
==========================================
- Hits 7928 3253 -4675
+ Misses 1119 416 -703 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Uses the correct keys as described in: https://develop.sentry.dev/sdk/data-model/event-payloads/contexts/#feature-flag-context
💡 Motivation and Context
Feature flags were not visible on sentry.io
💚 How did you test it?
Unit tests. Tested with sample app.
https://sentry-sdks.sentry.io/issues/4349777516/events/latest/?project=5428562&query=is%3Aunresolved%20issue.category%3A%5Berror%2Coutage%5D&referrer=latest-event&stream_index=0
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps