Add module in SentryStackFrame#2931
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2931 +/- ##
=======================================
Coverage 87.63% 87.63%
=======================================
Files 278 278
Lines 9176 9180 +4
=======================================
+ Hits 8041 8045 +4
Misses 1135 1135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The current failures seem to be due to the CI setup. The integration test complains about a missing auth token, I suppose that's due to me being an outside contributor, and the non-integration test failure is due to 429 too many request flake. |
|
@buenaflor Is there anything left to do here? |
|
@buenaflor Friendly ping to get this merged :) |
|
Last I checked (a month ago) it did not break grouping but unfortunately now it does so we can't merge it as it is currently. I'm not sure if something changed in the backend grouping behaviour. We can make this opt-in but I'm convinced no one will ever enable it if it is |
|
So what's the way forward here? This functionality is super valuable for us, and I don't see how to make this possible without any changes to the SDK itself |
|
If you really need it then I'd put it behind a flag (opt-in), maybe |
📜 Description
For package frames, the module gets now reported. This allows users to use the
stack.modulefilter in the Sentry search.💡 Motivation and Context
#2929
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps