Skip to content

fix: onError should be handled: false by default#2901

Merged
buenaflor merged 6 commits into
mainfrom
fix/on-error-handled
May 5, 2025
Merged

fix: onError should be handled: false by default#2901
buenaflor merged 6 commits into
mainfrom
fix/on-error-handled

Conversation

@buenaflor

@buenaflor buenaflor commented Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

📜 Description

💡 Motivation and Context

Closes #2898

Note:

  • I checked and this does not affect grouping
  • This will however affect crash free rate but we're still including this in a new major so we have to call this out properly

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov

codecov Bot commented Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.15%. Comparing base (eddb316) to head (5241b2d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2901      +/-   ##
==========================================
+ Coverage   87.63%   89.15%   +1.52%     
==========================================
  Files         272       93     -179     
  Lines        9048     3081    -5967     
==========================================
- Hits         7929     2747    -5182     
+ Misses       1119      334     -785

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 469.73 ms 508.40 ms 38.67 ms
Size 6.44 MiB 7.43 MiB 1013.22 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a22e451 464.31 ms 548.44 ms 84.13 ms
85b58ca 435.86 ms 509.48 ms 73.62 ms
40680d3 323.55 ms 390.29 ms 66.73 ms
8d64376 302.88 ms 356.84 ms 53.96 ms
2a0edba 376.12 ms 454.00 ms 77.88 ms
039058a 448.52 ms 512.55 ms 64.03 ms
8a7f528 290.27 ms 341.80 ms 51.53 ms
e8603bb 377.51 ms 444.77 ms 67.26 ms
62ae1b3 419.60 ms 494.14 ms 74.54 ms
d0476e1 412.20 ms 492.62 ms 80.42 ms

App size

Revision Plain With Sentry Diff
a22e451 6.46 MiB 7.48 MiB 1.02 MiB
85b58ca 6.46 MiB 7.48 MiB 1.01 MiB
40680d3 6.06 MiB 7.03 MiB 989.25 KiB
8d64376 5.94 MiB 6.96 MiB 1.02 MiB
2a0edba 6.33 MiB 7.30 MiB 992.46 KiB
039058a 6.52 MiB 7.59 MiB 1.06 MiB
8a7f528 6.06 MiB 7.03 MiB 989.36 KiB
e8603bb 6.34 MiB 7.28 MiB 967.80 KiB
62ae1b3 6.35 MiB 7.40 MiB 1.05 MiB
d0476e1 6.35 MiB 7.40 MiB 1.05 MiB

Previous results on branch: fix/on-error-handled

Startup times

Revision Plain With Sentry Diff
dacb7f2 428.10 ms 500.48 ms 72.38 ms
cfc177d 491.10 ms 544.89 ms 53.79 ms

App size

Revision Plain With Sentry Diff
dacb7f2 6.44 MiB 7.43 MiB 1012.84 KiB
cfc177d 6.44 MiB 7.43 MiB 1012.84 KiB

@github-actions

github-actions Bot commented Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1258.63 ms 1273.37 ms 14.73 ms
Size 8.43 MiB 10.01 MiB 1.58 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
48a9615 1243.69 ms 1256.47 ms 12.77 ms
1a93825 1257.25 ms 1261.55 ms 4.30 ms
68677de 1245.20 ms 1273.51 ms 28.31 ms
b6ed221 1256.90 ms 1272.51 ms 15.61 ms
294b7f0 1243.55 ms 1258.53 ms 14.98 ms
134c9f8 1284.48 ms 1306.18 ms 21.70 ms
ddd99d0 1235.98 ms 1253.06 ms 17.08 ms
8a7f528 1232.57 ms 1249.82 ms 17.24 ms
c732386 1233.20 ms 1252.08 ms 18.88 ms
b728df4 1287.43 ms 1293.94 ms 6.51 ms

App size

Revision Plain With Sentry Diff
48a9615 8.43 MiB 10.01 MiB 1.58 MiB
1a93825 8.28 MiB 9.34 MiB 1.05 MiB
68677de 8.10 MiB 9.16 MiB 1.07 MiB
b6ed221 8.43 MiB 9.99 MiB 1.56 MiB
294b7f0 8.32 MiB 9.38 MiB 1.06 MiB
134c9f8 8.16 MiB 9.16 MiB 1.01 MiB
ddd99d0 8.42 MiB 9.91 MiB 1.49 MiB
8a7f528 8.10 MiB 9.16 MiB 1.06 MiB
c732386 8.28 MiB 9.33 MiB 1.05 MiB
b728df4 8.15 MiB 9.15 MiB 1020.72 KiB

Previous results on branch: fix/on-error-handled

Startup times

Revision Plain With Sentry Diff
cfc177d 1259.26 ms 1270.60 ms 11.35 ms

App size

Revision Plain With Sentry Diff
cfc177d 8.43 MiB 10.01 MiB 1.58 MiB

@buenaflor
buenaflor requested a review from denrase April 30, 2025 11:04
@buenaflor
buenaflor marked this pull request as ready for review April 30, 2025 12:25
@buenaflor

buenaflor commented Apr 30, 2025

Copy link
Copy Markdown
Contributor Author

@ueman since you added this integration back then do you have any concerns with this change?

buenaflor
buenaflor commented Apr 30, 2025
View reviewed changes
Comment thread flutter/lib/src/integrations/on_error_integration.dart
denrase
denrase approved these changes Apr 30, 2025
View reviewed changes

@denrase denrase left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@buenaflor
buenaflor merged commit b3d62f0 into main May 5, 2025
@buenaflor
buenaflor deleted the fix/on-error-handled branch May 5, 2025 11:23
@buenaflor buenaflor mentioned this pull request May 6, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denrase denrase denrase approved these changes
@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich
@stefanosiano stefanosiano Awaiting requested review from stefanosiano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

onError should by default be unhandled

2 participants

@buenaflor @denrase