Skip to content

Add message parameter to captureException#2882

Merged
buenaflor merged 15 commits into
getsentry:mainfrom
ueman:add-message
Jun 17, 2025
Merged

Add message parameter to captureException#2882
buenaflor merged 15 commits into
getsentry:mainfrom
ueman:add-message

Conversation

@ueman

@ueman ueman commented Apr 22, 2025

Copy link
Copy Markdown
Collaborator

📜 Description

Fixes #2844

💡 Motivation and Context

This is useful if you want to add additional context to a captured exception

💚 How did you test it?

Added tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov

codecov Bot commented Apr 22, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.63%. Comparing base (78793c5) to head (826957e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2882      +/-   ##
==========================================
+ Coverage   87.60%   87.63%   +0.02%     
==========================================
  Files         278      278              
  Lines        9176     9176              
==========================================
+ Hits         8039     8041       +2     
+ Misses       1137     1135       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread CHANGELOG.md Outdated
@ueman
ueman marked this pull request as draft April 23, 2025 19:04
@ueman

ueman commented Apr 25, 2025

Copy link
Copy Markdown
Collaborator Author

@denrase What am I doing wrong when regenerating the mocks via the build_runner? Somehow, I get a bunch of incompatible code and I don't really understand why

@denrase

denrase commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

@ueman Had the same issues today. I resolved it by switching to the beta flutter channel, upgrading to the latest version and running flutter pub run build_runner build there from the sentry-dart/flutter directory.

@denrase

denrase commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

@ueman Sorry for the late reply 🙈

@ueman
ueman marked this pull request as ready for review May 13, 2025 05:51
@ueman
ueman requested a review from denrase as a code owner May 13, 2025 05:51
@ueman

ueman commented May 14, 2025

Copy link
Copy Markdown
Collaborator Author

@denrase @buenaflor I'm not sure whether this is should be considered a breaking change, but if so, it would be nice to have it included in v9 :D This is also ready for review and the failing checks are due to a missing auth token for the integration test, presumable due to me being an outside contributor.

@buenaflor

Copy link
Copy Markdown
Contributor

afaict it's not a breaking change but I'll have a closer look

@ueman

ueman commented May 19, 2025

Copy link
Copy Markdown
Collaborator Author

@buenaflor Are there any news?

@buenaflor

Copy link
Copy Markdown
Contributor

Changes look fine to me but I wanna merge this once v9 is out

@ueman

ueman commented Jun 17, 2025

Copy link
Copy Markdown
Collaborator Author

@buenaflor Friendly ping to get this merged :)

@buenaflor buenaflor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@buenaflor
buenaflor merged commit 998969c into getsentry:main Jun 17, 2025
140 of 144 checks passed
@ueman
ueman deleted the add-message branch June 17, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a way to add a message to captureException

3 participants