v9: Remove other from SentryRequest#2879
Merged
Merged
Conversation
buenaflor
requested review from
krystofwoldrich and
stefanosiano
as code owners
April 22, 2025 11:07
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2879 +/- ##
==========================================
- Coverage 87.68% 87.63% -0.06%
==========================================
Files 272 272
Lines 9037 9032 -5
==========================================
- Hits 7924 7915 -9
- Misses 1113 1117 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0095354 | 511.17 ms | 549.12 ms | 37.96 ms |
| 4bcf446 | 497.87 ms | 533.48 ms | 35.61 ms |
| 231f523 | 443.96 ms | 520.20 ms | 76.24 ms |
| bc29768 | 396.19 ms | 472.27 ms | 76.08 ms |
| 26e955b | 369.52 ms | 458.60 ms | 89.07 ms |
| a758ebd | 556.55 ms | 588.14 ms | 31.59 ms |
| 2b9937e | 439.68 ms | 478.38 ms | 38.70 ms |
| 7748b7c | 356.37 ms | 426.70 ms | 70.33 ms |
| cfa25fc | 351.73 ms | 427.65 ms | 75.92 ms |
| cf91c9d | 383.96 ms | 458.98 ms | 75.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0095354 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
| 4bcf446 | 6.49 MiB | 7.56 MiB | 1.07 MiB |
| 231f523 | 6.44 MiB | 7.50 MiB | 1.06 MiB |
| bc29768 | 6.33 MiB | 7.26 MiB | 947.07 KiB |
| 26e955b | 6.27 MiB | 7.20 MiB | 956.49 KiB |
| a758ebd | 6.49 MiB | 7.57 MiB | 1.08 MiB |
| 2b9937e | 6.49 MiB | 7.56 MiB | 1.07 MiB |
| 7748b7c | 6.27 MiB | 7.20 MiB | 959.09 KiB |
| cfa25fc | 6.33 MiB | 7.30 MiB | 987.47 KiB |
| cf91c9d | 6.34 MiB | 7.28 MiB | 966.33 KiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1edf30e | 1254.43 ms | 1272.82 ms | 18.39 ms |
| 2f8f173 | 1280.61 ms | 1292.20 ms | 11.59 ms |
| 0b7de9a | 1254.45 ms | 1271.22 ms | 16.78 ms |
| ecb4003 | 1266.94 ms | 1290.24 ms | 23.31 ms |
| 95c69e3 | 1223.94 ms | 1245.29 ms | 21.35 ms |
| 90db9ff | 1277.18 ms | 1283.69 ms | 6.51 ms |
| 0aa80ac | 1275.92 ms | 1278.63 ms | 2.72 ms |
| be7a831 | 1262.78 ms | 1282.98 ms | 20.20 ms |
| f79eecf | 1210.25 ms | 1221.65 ms | 11.40 ms |
| 05933ac | 1258.37 ms | 1285.57 ms | 27.21 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1edf30e | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 2f8f173 | 8.15 MiB | 9.13 MiB | 1000.39 KiB |
| 0b7de9a | 8.42 MiB | 9.91 MiB | 1.48 MiB |
| ecb4003 | 8.09 MiB | 9.07 MiB | 1000.82 KiB |
| 95c69e3 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| 90db9ff | 8.10 MiB | 9.08 MiB | 1004.27 KiB |
| 0aa80ac | 8.43 MiB | 9.99 MiB | 1.56 MiB |
| be7a831 | 8.38 MiB | 9.77 MiB | 1.40 MiB |
| f79eecf | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| 05933ac | 8.38 MiB | 9.78 MiB | 1.40 MiB |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Part of v9, this field is not part of the specs anymore and was planned to be removed in v8
Closes #1441
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps