Make hierarchical exception grouping opt-in#2858
Merged
Merged
Conversation
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2858 +/- ##
==========================================
- Coverage 87.70% 87.68% -0.02%
==========================================
Files 272 272
Lines 9026 9031 +5
==========================================
+ Hits 7916 7919 +3
- Misses 1110 1112 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
denrase
marked this pull request as ready for review
April 14, 2025 13:35
denrase
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
April 14, 2025 13:35
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6daa837 | 1250.42 ms | 1265.60 ms | 15.18 ms |
| 8776cdf | 1237.64 ms | 1246.83 ms | 9.20 ms |
| c689845 | 1249.12 ms | 1264.79 ms | 15.66 ms |
| 7d5e695 | 1230.20 ms | 1265.40 ms | 35.20 ms |
| 7954fb3 | 1247.20 ms | 1272.15 ms | 24.94 ms |
| 03e4c9b | 1241.96 ms | 1247.00 ms | 5.04 ms |
| 31b2afb | 1244.90 ms | 1261.37 ms | 16.47 ms |
| 7359546 | 1252.02 ms | 1271.55 ms | 19.53 ms |
| 294b7f0 | 1243.55 ms | 1258.53 ms | 14.98 ms |
| cdf7172 | 1264.43 ms | 1291.39 ms | 26.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6daa837 | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| 8776cdf | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| c689845 | 8.42 MiB | 9.86 MiB | 1.44 MiB |
| 7d5e695 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
| 7954fb3 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
| 03e4c9b | 8.34 MiB | 9.67 MiB | 1.33 MiB |
| 31b2afb | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| 7359546 | 8.42 MiB | 9.83 MiB | 1.40 MiB |
| 294b7f0 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
| cdf7172 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
buenaflor
approved these changes
Apr 15, 2025
buenaflor
left a comment
buenaflor
left a comment
Contributor
There was a problem hiding this comment.
let's merge it now, if later on it's possible from backend side to fix grouping then we can remove the opt-in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Make hierarchical exception grouping opt-in
💡 Motivation and Context
Relates to #2857
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled