Skip to content

[v9]: Update naming of LoadImagesListIntegration#2833

Merged
buenaflor merged 6 commits into
mainfrom
v9-feat/change-name-of-load-images-integration
Apr 2, 2025
Merged

[v9]: Update naming of LoadImagesListIntegration#2833
buenaflor merged 6 commits into
mainfrom
v9-feat/change-name-of-load-images-integration

Conversation

@buenaflor

@buenaflor buenaflor commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

📜 Description

Renames LoadImagesListIntegration -> LoadNativeDebugImagesIntegration

💡 Motivation and Context

v9 issue

Closes #2834

💚 How did you test it?

Existing tests

@codecov

codecov Bot commented Apr 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (3fcbad3) to head (5979c27).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2833   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         265      265           
  Lines        8867     8867           
=======================================
  Hits         7850     7850           
  Misses       1017     1017           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 430.77 ms 482.77 ms 52.00 ms
Size 6.44 MiB 7.44 MiB 1015.90 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
03e4c9b 410.34 ms 493.20 ms 82.86 ms
0a82a1e 321.02 ms 393.82 ms 72.80 ms
6fedcab 388.26 ms 487.42 ms 99.16 ms
803f3a9 424.66 ms 505.24 ms 80.58 ms
ffae3e3 360.67 ms 466.24 ms 105.57 ms
bf4aed7 311.24 ms 365.66 ms 54.42 ms
ddc97ad 331.45 ms 384.06 ms 52.61 ms
d53c6fa 282.83 ms 344.00 ms 61.17 ms
f922f8f 332.31 ms 374.67 ms 42.37 ms
547db82 453.40 ms 482.88 ms 29.48 ms

App size

Revision Plain With Sentry Diff
03e4c9b 6.35 MiB 7.42 MiB 1.07 MiB
0a82a1e 6.15 MiB 7.11 MiB 981.82 KiB
6fedcab 6.33 MiB 7.30 MiB 987.83 KiB
803f3a9 6.46 MiB 7.48 MiB 1.02 MiB
ffae3e3 6.26 MiB 7.20 MiB 958.78 KiB
bf4aed7 6.06 MiB 7.03 MiB 997.04 KiB
ddc97ad 6.16 MiB 7.14 MiB 1003.75 KiB
d53c6fa 6.16 MiB 7.14 MiB 1011.18 KiB
f922f8f 5.94 MiB 6.95 MiB 1.01 MiB
547db82 6.49 MiB 7.56 MiB 1.07 MiB

@denrase denrase left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good!

@buenaflor
buenaflor merged commit 8db16fc into main Apr 2, 2025
@buenaflor
buenaflor deleted the v9-feat/change-name-of-load-images-integration branch April 2, 2025 13:14
@github-actions

github-actions Bot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor
Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Update naming of `LoadImagesListIntegration` ([#2833](https://github.com/getsentry/sentry-dart/pull/2833))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 5979c27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v9]: Update LoadImagesListIntegration naming to LoadNativeDebugImagesIntegration

2 participants