Fix: Improve platform memory collection on windows/linux#2798
Merged
Conversation
6 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## temp/8.14.1 #2798 +/- ##
===============================================
- Coverage 88.97% 88.91% -0.06%
===============================================
Files 263 263
Lines 8931 8951 +20
===============================================
+ Hits 7946 7959 +13
- Misses 985 992 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Comment regarding free memory removal: #2774 (review) |
denrase
marked this pull request as ready for review
March 17, 2025 13:57
denrase
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
March 17, 2025 13:57
buenaflor
added a commit
that referenced
this pull request
Mar 24, 2025
* Fix: Improve platform memory collection on windows/linux (#2798) * deps: bump Android from `7.22.1` to `7.22.4` (#2810) * update android deps * Update CHANGELOG.md * Fix adding runtime to contexts (#2813) * Fix CHANGELOG formatting * release: 8.14.1 * Update CHANGELOG * Use options.platform instead of options.platformChecker --------- Co-authored-by: Denis Andrašec <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>
buenaflor
added a commit
that referenced
this pull request
Apr 24, 2025
* Fix: Improve platform memory collection on windows/linux (#2798) * deps: bump Android from `7.22.1` to `7.22.4` (#2810) * update android deps * Update CHANGELOG.md * Fix adding runtime to contexts (#2813) * Fix CHANGELOG formatting * release: 8.14.1 * fix: `options.diagnosticLevel` not affecting logs (#2856) * v9: Set log level to `warning` by default (#2836) * update * update test * update init native sdk test * Update CHANGELOG * Add additional test * Update CHANGELOG * Update CHANGELOG * Update * Update * Fix test * Fix test * Fix analyze * Remove prod scheme * Update mocks * Update mocks * Improve performance of frames tracking (#2854) * Improve performance * Update tests * Improve performance * Formatting * Separate function * Remove separate function * Update * Improve frames tracking performance * update naming * Update * update * update * Edge case * Update mocks * formatting * Improvements * Analyze * Update mocks * Update mocks * Clean up `getSpan()` log (#2865) * Remove unnecessary log and document the behaviour * Typo * Typo * Add CHANGELOG entry * release: 8.14.2 * Update * Update --------- Co-authored-by: Denis Andrašec <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
A user reported an issue where his http calls are way slower if wrapped in sentry transactions. Turns out this is because we call external binaries with exec for every transaction to get physical and free memory size. Turns out this has a large overhead. Also the binary used on windows was deprecated and may therefore not be present. So we have the large overhead without the benefit.
This PR introduces the following to mitigate/fix all of the above:
Update: free memory has been removed currently on Desktop
💡 Motivation and Context
Relates to #2760
Relates to onepub-dev/system_info#12
💚 How did you test it?
Ran locally in a win 11 vm. Unit tests.
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps