Skip to content

Bind root screen transaction to scope#2756

Merged
denrase merged 8 commits into
mainfrom
fix/bind-root-transaction-to-scope
Mar 11, 2025
Merged

Bind root screen transaction to scope#2756
denrase merged 8 commits into
mainfrom
fix/bind-root-transaction-to-scope

Conversation

@denrase

@denrase denrase commented Feb 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📜 Description

Possible fix for #2753. Binding the root screen transaction to the scope, so error events can reference it.

Before:

Bildschirmfoto 2025-02-26 um 16 50 25

After:

Bildschirmfoto 2025-02-26 um 17 03 03

💡 Motivation and Context

Relates to #2753

💚 How did you test it?

Added unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov

codecov Bot commented Feb 26, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (3b5a71f) to head (0cc2d79).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2756      +/-   ##
==========================================
+ Coverage   88.95%   92.07%   +3.12%     
==========================================
  Files         263       91     -172     
  Lines        8925     2952    -5973     
==========================================
- Hits         7939     2718    -5221     
+ Misses        986      234     -752

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Feb 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 491.37 ms 563.70 ms 72.33 ms
Size 6.44 MiB 7.50 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
333903e 332.76 ms 406.86 ms 74.10 ms
3a16179 471.61 ms 513.45 ms 41.83 ms
8e133ad 360.08 ms 402.82 ms 42.74 ms
84bc635 395.57 ms 464.23 ms 68.66 ms
94757e3 480.21 ms 515.28 ms 35.07 ms
eb1a7c1 332.98 ms 381.55 ms 48.57 ms
891efac 378.00 ms 461.20 ms 83.20 ms
633cf2e 289.36 ms 340.38 ms 51.02 ms
ec4c9da 476.70 ms 514.04 ms 37.34 ms
d7dc4e5 472.08 ms 527.98 ms 55.90 ms

App size

Revision Plain With Sentry Diff
333903e 6.06 MiB 7.10 MiB 1.04 MiB
3a16179 6.52 MiB 7.61 MiB 1.08 MiB
8e133ad 6.06 MiB 7.03 MiB 990.29 KiB
84bc635 6.34 MiB 7.28 MiB 968.41 KiB
94757e3 6.49 MiB 7.57 MiB 1.08 MiB
eb1a7c1 5.94 MiB 6.92 MiB 1005.76 KiB
891efac 6.27 MiB 7.20 MiB 958.73 KiB
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB
ec4c9da 6.52 MiB 7.59 MiB 1.06 MiB
d7dc4e5 6.46 MiB 7.48 MiB 1.02 MiB

Previous results on branch: fix/bind-root-transaction-to-scope

Startup times

Revision Plain With Sentry Diff
ec1c3ed 447.89 ms 509.20 ms 61.31 ms
f5a3e49 426.98 ms 504.94 ms 77.96 ms
e0238d2 439.94 ms 501.28 ms 61.34 ms

App size

Revision Plain With Sentry Diff
ec1c3ed 6.46 MiB 7.48 MiB 1.02 MiB
f5a3e49 6.46 MiB 7.48 MiB 1.02 MiB
e0238d2 6.46 MiB 7.48 MiB 1.02 MiB

@github-actions

github-actions Bot commented Feb 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1266.53 ms 1287.41 ms 20.88 ms
Size 8.43 MiB 9.97 MiB 1.54 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
90a08ea 1260.45 ms 1285.24 ms 24.80 ms
5f443de 1253.37 ms 1277.31 ms 23.95 ms
e3ef570 1220.08 ms 1239.66 ms 19.58 ms
b2cbbc8 1240.00 ms 1254.37 ms 14.37 ms
d0476e1 1259.45 ms 1280.31 ms 20.86 ms
ffae3e3 1215.82 ms 1238.49 ms 22.67 ms
12ed940 1239.55 ms 1261.32 ms 21.77 ms
c1bb00f 1265.14 ms 1290.85 ms 25.71 ms
6491ebd 1231.41 ms 1245.35 ms 13.94 ms
19a9adb 1249.21 ms 1258.31 ms 9.09 ms

App size

Revision Plain With Sentry Diff
90a08ea 8.38 MiB 9.73 MiB 1.36 MiB
5f443de 8.33 MiB 9.58 MiB 1.25 MiB
e3ef570 8.32 MiB 9.38 MiB 1.06 MiB
b2cbbc8 8.10 MiB 9.18 MiB 1.08 MiB
d0476e1 8.33 MiB 9.64 MiB 1.31 MiB
ffae3e3 8.28 MiB 9.33 MiB 1.05 MiB
12ed940 8.42 MiB 9.97 MiB 1.54 MiB
c1bb00f 8.09 MiB 9.07 MiB 1001.06 KiB
6491ebd 8.29 MiB 9.36 MiB 1.07 MiB
19a9adb 8.42 MiB 9.86 MiB 1.44 MiB

Previous results on branch: fix/bind-root-transaction-to-scope

Startup times

Revision Plain With Sentry Diff
ec1c3ed 1250.45 ms 1267.80 ms 17.35 ms
f5a3e49 1264.00 ms 1273.25 ms 9.25 ms
e0238d2 1234.84 ms 1241.61 ms 6.78 ms

App size

Revision Plain With Sentry Diff
ec1c3ed 8.42 MiB 9.97 MiB 1.55 MiB
f5a3e49 8.42 MiB 9.97 MiB 1.55 MiB
e0238d2 8.42 MiB 9.97 MiB 1.55 MiB

@denrase
denrase marked this pull request as ready for review March 5, 2025 14:27
buenaflor
buenaflor approved these changes Mar 11, 2025
View reviewed changes

@buenaflor buenaflor left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think that was an oversight, it should've been bound to scope

@denrase
denrase merged commit 231f523 into main Mar 11, 2025
@denrase
denrase deleted the fix/bind-root-transaction-to-scope branch March 11, 2025 15:50
buenaflor added a commit that referenced this pull request Mar 12, 2025
@buenaflor @getsentry-bot
@denrase @github-actions @web-flow getsentry-bot
Merge main into v9 branch (#2788)
a3b2356 
* update Android dependency to 7.22.0 (#2705)

* fix: navigation breadcrumb with missing to crashes native (#2720)

* release: 8.13.1

* update changelog

* fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736)

* fix

* regenerate mocks

* update CHANGELOG

* update test

* update

* fix test

* release: 8.13.2

* Use global ruby for  `pod  install` in min version test (#2783)

* chore(deps): update Cocoa SDK to v8.46.0 (#2772)

* chore: update flutter/scripts/update-cocoa.sh to 8.46.0

* Update CHANGELOG.md

---------

Co-authored-by: GitHub <[email protected]>
Co-authored-by: Giancarlo Buenaflor <[email protected]>

* Bind root screen transaction to scope (#2756)

* chore(deps): update Android SDK to v7.22.1 (#2785)

* update android dep

* update changelog

* update CHANGELOG

* release: 8.13.3

* update CHANGELOG

* Prepare `8.14.0` changelog (#2787)

* update CHANGELOG

* update

* Update CHANGELOG.md

* Update CHANGELOG.md

* release: 8.14.0

---------

Co-authored-by: getsentry-bot <[email protected]>
Co-authored-by: Denis Andrašec <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub <[email protected]>
Co-authored-by: getsentry-bot <[email protected]>
@kahest kahest mentioned this pull request Apr 7, 2025
Closed
@smeubank smeubank linked an issue Apr 9, 2025 that may be closed by this pull request
Errors and not being linked to Spans in traces #2753
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buenaflor buenaflor buenaflor approved these changes
@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich
@stefanosiano stefanosiano Awaiting requested review from stefanosiano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Errors and not being linked to Spans in traces

2 participants

@denrase @buenaflor