Move replay and privacy from experimental to options#2755
Merged
Conversation
Contributor
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v9 #2755 +/- ##
==========================================
+ Coverage 88.49% 89.70% +1.21%
==========================================
Files 262 91 -171
Lines 8750 2952 -5798
==========================================
- Hits 7743 2648 -5095
+ Misses 1007 304 -703 ☔ View full report in Codecov by Sentry. |
denrase
marked this pull request as ready for review
February 25, 2025 16:20
denrase
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
February 25, 2025 16:20
vaind
approved these changes
Feb 26, 2025
vaind
left a comment
vaind
left a comment
Contributor
There was a problem hiding this comment.
LGTM other than the changelog item
| - Responses are attached to the `Hint` object, which can be read in `beforeSend`/`beforeSendTransaction` callbacks via `hint.response`. | ||
| - For now, only the `dio` integration is supported. | ||
| - Enable privacy masking for screenshots by default ([#2728](https://github.com/getsentry/sentry-dart/pull/2728)) | ||
| - Move replay and privacy from experimental to options ([#2755](https://github.com/getsentry/sentry-dart/pull/2755)) |
Contributor
There was a problem hiding this comment.
This should go to a new Unreleased section in preparation for the next alpha
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| ## 9.0.0 Unreleased | ||
|
|
||
| - Move replay and privacy from experimental to options ([#2755](https://github.com/getsentry/sentry-dart/pull/2755)) |
Contributor
There was a problem hiding this comment.
- 🚫 The changelog entry seems to be part of an already released section
## 9.0.0.
Consider moving the entry to the## Unreleasedsection, please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Move replay and privacy from experimental to options
💡 Motivation and Context
prep for v9
💚 How did you test it?
Run tests
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps