Pass missing captureFailedRequests param to FailedRequestInterceptor#2744
Merged
Conversation
Maatteogekko
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
February 21, 2025 16:42
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2744 +/- ##
==========================================
+ Coverage 88.96% 94.55% +5.59%
==========================================
Files 263 9 -254
Lines 8925 202 -8723
==========================================
- Hits 7940 191 -7749
+ Misses 985 11 -974 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Should I add the changelog entry like the failing job suggests? |
Contributor
|
Hi @Maatteogekko, Yes, please, add a changelog entry. |
denrase
requested changes
Mar 4, 2025
Collaborator
There was a problem hiding this comment.
Hey @Maatteogekko ! Thank you for contributing!
Code looks good, I took the liberty to write a test locally which you could just paste in addition to syncing with main. After that we can merge.
- In
sentry_dio_extension.dartplease also pass thehub:
interceptors.insert(
0,
FailedRequestInterceptor(
hub: hub,
failedRequestStatusCodes: failedRequestStatusCodes,
failedRequestTargets: failedRequestTargets,
captureFailedRequests: captureFailedRequests,
),
);- In
sentry_dio_extension.testreplace theaddSentry adds $FailedRequestInterceptor if override truewith the following:
test('addSentry adds $FailedRequestInterceptor if override true', () {
final dio = fixture.getSut();
fixture.hub.options.captureFailedRequests = false;
dio.addSentry(hub: fixture.hub, captureFailedRequests: true);
expect(
dio.interceptors.whereType<FailedRequestInterceptor>().length,
1,
);
final interceptor = dio.interceptors.whereType<FailedRequestInterceptor>().first;
final requestOptions = RequestOptions(path: 'https://example.com');
final error = DioError(
requestOptions: requestOptions,
response: Response(statusCode: 500, requestOptions: requestOptions),
);
interceptor.onError(error, fixture.errorInterceptorHandler);
expect(fixture.hub.captureExceptionCalls.length, 1);
});and fixure:
class Fixture {
final MockHub hub = MockHub();
final errorInterceptorHandler = MockedErrorInterceptorHandler();
Dio getSut() {
return Dio();
}
}That way we have covered your contribution by a test case. Thank you! 🙇♂️
denrase
enabled auto-merge (squash)
March 5, 2025 12:58
denrase
approved these changes
Mar 5, 2025
Collaborator
|
Ok, looks like auto-merge is ignoring CI. 🤦♂️ @kahest I'm gonna check out main and fix if needed. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
dio.addSentry() captureFailedRequest param passed through to FailedRequestInterceptor.
💡 Motivation and Context
Fixes #2737.
💚 How did you test it?
I have run the fix in my app and it works as expected.
📝 Checklist
sendDefaultPiiis enabled